Bug 1767655

Summary: Sometimes dockercfg secret is not cleaned up when token deleted
Product: OpenShift Container Platform Reporter: Clayton Coleman <ccoleman>
Component: openshift-controller-managerAssignee: Adam Kaplan <adam.kaplan>
Status: CLOSED DUPLICATE QA Contact: wewang <wewang>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.3.0CC: aos-bugs, mfojtik
Target Milestone: ---   
Target Release: 4.3.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-11-01 20:58:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Clayton Coleman 2019-10-31 22:27:14 UTC
We've been having flakes with the TestDockercfgTokenDeletedController e2e test for a while.  I've added enough debugging that it looks like the actual functionality is broken and only works ~70% of the time in the test.

Someone needs to identify why dockercfg secret deletion is buggy (probably a data race) and fix it.  The consequence here is that we may have invalid pull secrets being mounted into pods, especially during cert or token rotation.

https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/logs/release-openshift-origin-installer-e2e-gcp-4.3/528

Comment 1 Clayton Coleman 2019-10-31 22:35:38 UTC
This test was not flaking before 10/24 - so something changed in master before that.

Comment 2 Adam Kaplan 2019-11-01 20:42:23 UTC
Per Clayton's comment, marking this as a release blocker.

Comment 3 Adam Kaplan 2019-11-01 20:58:35 UTC

*** This bug has been marked as a duplicate of bug 1765294 ***