Bug 1767655 - Sometimes dockercfg secret is not cleaned up when token deleted
Summary: Sometimes dockercfg secret is not cleaned up when token deleted
Keywords:
Status: CLOSED DUPLICATE of bug 1765294
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: openshift-controller-manager
Version: 4.3.0
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
: 4.3.0
Assignee: Adam Kaplan
QA Contact: wewang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-10-31 22:27 UTC by Clayton Coleman
Modified: 2019-11-01 20:58 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-11-01 20:58:35 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Clayton Coleman 2019-10-31 22:27:14 UTC
We've been having flakes with the TestDockercfgTokenDeletedController e2e test for a while.  I've added enough debugging that it looks like the actual functionality is broken and only works ~70% of the time in the test.

Someone needs to identify why dockercfg secret deletion is buggy (probably a data race) and fix it.  The consequence here is that we may have invalid pull secrets being mounted into pods, especially during cert or token rotation.

https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/logs/release-openshift-origin-installer-e2e-gcp-4.3/528

Comment 1 Clayton Coleman 2019-10-31 22:35:38 UTC
This test was not flaking before 10/24 - so something changed in master before that.

Comment 2 Adam Kaplan 2019-11-01 20:42:23 UTC
Per Clayton's comment, marking this as a release blocker.

Comment 3 Adam Kaplan 2019-11-01 20:58:35 UTC

*** This bug has been marked as a duplicate of bug 1765294 ***


Note You need to log in before you can comment on or make changes to this bug.