Bug 1768698
Summary: | hot-backup.py is no longer working | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | NM <andrew.kavalov> | ||||
Component: | subversion | Assignee: | Joe Orton <jorton> | ||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | low | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | 32 | CC: | jorton, orion, vanmeeuwen+fedora | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | x86_64 | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | subversion-1.14.1-1.fc33 | Doc Type: | If docs needed, set a value | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2021-02-12 01:43:02 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
NM
2019-11-05 02:46:05 UTC
Can yo8 please confirm observing (or not) the same. Thanks. *you Yes likely some or many of the scripts on the -tools directory don't work with Python 3 yet, sorry. Work is progressing upstream on improving support for py3. Understood. Thanks. This bug appears to have been reported against 'rawhide' during the Fedora 32 development cycle. Changing version to 32. This is present in F31 as well - subversion-tools-1.12.2-3.fc31 Is there an upstream issue we can track? I'm not finding a particular one for hot-backup. My naive fix: diff -up subversion-1.12.2/tools/backup/hot-backup.py.in.py3 subversion-1.12.2/tools/backup/hot-backup.py.in --- subversion-1.12.2/tools/backup/hot-backup.py.in.py3 2015-12-21 08:02:31.000000000 -0700 +++ subversion-1.12.2/tools/backup/hot-backup.py.in 2020-05-07 16:26:50.792984845 -0600 @@ -219,7 +219,7 @@ def get_youngest_revision(): raise Exception("Unable to find the youngest revision for repository '%s'" ": %s" % (repo_dir, stderr_lines[0].rstrip())) - return stdout_lines[0].strip() + return stdout_lines[0].strip().decode() ###################################################################### # Main Created attachment 1686353 [details]
Patch for hot-backup.py for python3
Sorry, that previous one was incomplete. This seems to be working for me.
Just updated to FC32. Problem persists: Traceback (most recent call last): File "/usr/share/doc/subversion-tools/backup/hot-backup.py", line 244, in <module> backup_subdir = os.path.join(backup_dir, repo + "-" + youngest) TypeError: can only concatenate str (not "bytes") to str This is being actively discussed on the development list - https://lists.apache.org/thread.html/r81f95ce704e1b17138a39e075d6cbc7e42d2fcef3caccfd7d5f034cb%40%3Cdev.subversion.apache.org%3E I can backport whatever is committed upstream. Same error is observed in FC33. Would it be possible to package the solution proposed above for everyone else to enjoy it too via 'dnf install ...'? Ping. Just updated to F33 and had to patch this again. Package: subversion-1.14.1-1.fc34 Build: https://koji.fedoraproject.org/koji/buildinfo?buildID=1705901 I manually patched it too following instructions above. It would be nice to package it into a dnf package to resolve the issue once and forever. Thanks. Yup, it's fixed in 1.14.1 packages. Thank you very much. Do you know when it would hit the repos? Package: subversion-1.14.1-1.fc35 Build: https://koji.fedoraproject.org/koji/buildinfo?buildID=1705898 Package: subversion-1.14.1-1.fc33 Build: https://koji.fedoraproject.org/koji/buildinfo?buildID=1705903 Thank you very much. FEDORA-2021-a3a0273cb2 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-a3a0273cb2 FEDORA-2021-16e51e39a6 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2021-16e51e39a6 FEDORA-2021-a3a0273cb2 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2021-16e51e39a6 has been pushed to the Fedora 32 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-16e51e39a6` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-16e51e39a6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2021-16e51e39a6 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. |