Bug 1770173
| Summary: | Branch request: qtkeychain / qtkeychain-qt5 for EPEL8 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora EPEL | Reporter: | Leon Fauster <leonfauster> |
| Component: | qtkeychain | Assignee: | Troy Dawson <tdawson> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | epel8 | CC: | adam.winberg, boboshaq, bugzilla, germano.massullo, nonamedotc, tdawson |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | qtkeychain-0.9.1-4.el8.1 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-07-22 01:35:40 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1792987 | ||
|
Description
Leon Fauster
2019-11-08 11:37:40 UTC
I need this package in epel 8 too. I need it for Linux x86_x64 platform. This will require a little bit of modification of the spec file so that it does qt5 only. There is no qt4 in RHEL8.
If the package maintainer doesn't want to build this for epel, I can take it and build it, and put it with the other KDE packages I'm building for EPEL8.
If they do want to build it, the following patch to the qtkeychain-0.7.0-8.fc30 will get it to build. The newer 0.9.0 version doesn't work with what's currently in EPEL8.
@@ -1,8 +1,11 @@
+%if 0%{?fedora}
+%global qt4 1
+%endif
%global _hardened_build 1
Name: qtkeychain
Version: 0.7.0
-Release: 8%{?dist}
+Release: 8%{?dist}.1
Summary: A password store library
License: BSD
@@ -12,8 +15,10 @@ Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz
BuildRequires: gcc-c++
BuildRequires: cmake
+%if 0%{?qt4}
BuildRequires: pkgconfig(QtCore)
BuildRequires: pkgconfig(QtDBus)
+%endif
%description
The qtkeychain library allows you to store passwords easy and secure.
@@ -43,34 +48,45 @@ This package contains development files for qt5keychain.
%prep
%autosetup
+%if 0%{?qt4}
mkdir %{_target_platform}-qt4
+%endif
mkdir %{_target_platform}-qt5
%build
+%if 0%{?qt4}
pushd %{_target_platform}-qt4
%cmake .. \
-DBUILD_WITH_QT4:BOOL=ON \
-DCMAKE_BUILD_TYPE=RelWithDebInfo
popd
+%endif
pushd %{_target_platform}-qt5
%cmake .. \
-DBUILD_WITH_QT4:BOOL=OFF \
-DCMAKE_BUILD_TYPE=RelWithDebInfo
popd
+%if 0%{?qt4}
%make_build -C %{_target_platform}-qt4
+%endif
%make_build -C %{_target_platform}-qt5
%install
+%if 0%{?qt4}
%make_install -C %{_target_platform}-qt4
+%endif
%make_install -C %{_target_platform}-qt5
%find_lang %{name} --with-qt
+%if 0%{?qt4}
grep %{_qt4_translationdir} %{name}.lang > %{name}-qt4.lang
+%endif
grep %{_qt5_translationdir} %{name}.lang > %{name}-qt5.lang
+%if 0%{?qt4}
%ldconfig_scriptlets
%files -f %{name}-qt4.lang
@@ -82,6 +98,7 @@ grep %{_qt5_translationdir} %{name}.lang > %{name}-qt5.lang
%{_includedir}/qtkeychain/
%{_libdir}/cmake/QtKeychain/
%{_libdir}/libqtkeychain.so
+%endif
%ldconfig_scriptlets qt5
any updates on this? I am volunteering to package and maintain this package in EPEL8. Per the EPEL policy, if the maintainer doesn't respond back in a week (since this is the second time I've asked), I'll put a ticket in and will be made co-maintainer and be able to branch and build it in EPEL. As a side note, I think this package should be maintained by the kde-sig. Looking at the Fedora builds, it's been the kde-sig that has been maintaining it. I can add you as a co-maintainer. No problem. I don't remember when I took this package but it was going to be orphaned and I needed it for one of packages. What's your FAS? tdawson I have added you. Also made you EPEL8 contact. kde-sig is also now added. Thank You. Since this ticket is for Fedora EPEL, I'll take it and start working on it. Great. Thanks. Any news on this? Thank you for pinging me. I honestly thought I'd done it, but as you obviously can see, I didn't. I won't be able to get to it before the weekend, but I've put it on my list of packages to do then. I should have it in epel-testing next week sometime. FEDORA-EPEL-2020-ea970ec00a has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-ea970ec00a FEDORA-EPEL-2020-ea970ec00a has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-ea970ec00a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2020-ea970ec00a has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. |