Bug 1770173 - Branch request: qtkeychain / qtkeychain-qt5 for EPEL8
Summary: Branch request: qtkeychain / qtkeychain-qt5 for EPEL8
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora EPEL
Classification: Fedora
Component: qtkeychain
Version: epel8
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Troy Dawson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1792987
TreeView+ depends on / blocked
 
Reported: 2019-11-08 11:37 UTC by Leon Fauster
Modified: 2020-07-22 01:35 UTC (History)
6 users (show)

Fixed In Version: qtkeychain-0.9.1-4.el8.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-07-22 01:35:40 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Leon Fauster 2019-11-08 11:37:40 UTC
Description of problem:

qtkeychain-qt5 is in EPEL7 but not in EPEL8

https://apps.fedoraproject.org/packages/qtkeychain
https://koji.fedoraproject.org/koji/buildinfo?buildID=768091

Please consider adding it to EPEL8 (e.g. some RPMFUSION packages depend on it)


Version-Release number of selected component (if applicable):

Fedora SRPMS should be straight away buildable on EL8

Comment 1 boboshaq 2020-01-20 14:00:21 UTC
I need this package in epel 8 too.
I need it for Linux x86_x64 platform.

Comment 2 Troy Dawson 2020-02-26 22:36:16 UTC
This will require a little bit of modification of the spec file so that it does qt5 only.  There is no qt4 in RHEL8.
If the package maintainer doesn't want to build this for epel, I can take it and build it, and put it with the other KDE packages I'm building for EPEL8.
If they do want to build it, the following patch to the qtkeychain-0.7.0-8.fc30 will get it to build.  The newer 0.9.0 version doesn't work with what's currently in EPEL8.

@@ -1,8 +1,11 @@
+%if 0%{?fedora}
+%global qt4 1
+%endif
 %global _hardened_build 1
 
 Name:           qtkeychain
 Version:        0.7.0
-Release:        8%{?dist}
+Release:        8%{?dist}.1
 Summary:        A password store library
 
 License:        BSD
@@ -12,8 +15,10 @@ Source0:        %{url}/archive/v%{version}/%{name}-%{version}.tar.gz
 BuildRequires:  gcc-c++
 BuildRequires:  cmake
 
+%if 0%{?qt4}
 BuildRequires:  pkgconfig(QtCore)
 BuildRequires:  pkgconfig(QtDBus)
+%endif
 
 %description
 The qtkeychain library allows you to store passwords easy and secure.
@@ -43,34 +48,45 @@ This package contains development files for qt5keychain.
 
 %prep
 %autosetup
+%if 0%{?qt4}
 mkdir %{_target_platform}-qt4
+%endif
 mkdir %{_target_platform}-qt5
 
 %build
+%if 0%{?qt4}
 pushd %{_target_platform}-qt4
   %cmake .. \
     -DBUILD_WITH_QT4:BOOL=ON \
     -DCMAKE_BUILD_TYPE=RelWithDebInfo
 popd
+%endif
 pushd %{_target_platform}-qt5
   %cmake .. \
     -DBUILD_WITH_QT4:BOOL=OFF \
     -DCMAKE_BUILD_TYPE=RelWithDebInfo
 popd
 
+%if 0%{?qt4}
 %make_build -C %{_target_platform}-qt4
+%endif
 %make_build -C %{_target_platform}-qt5
 
 %install
+%if 0%{?qt4}
 %make_install -C %{_target_platform}-qt4
+%endif
 %make_install -C %{_target_platform}-qt5
 
 %find_lang %{name} --with-qt
 
+%if 0%{?qt4}
 grep %{_qt4_translationdir} %{name}.lang > %{name}-qt4.lang
+%endif
 grep %{_qt5_translationdir} %{name}.lang > %{name}-qt5.lang
 
 
+%if 0%{?qt4}
 %ldconfig_scriptlets
 
 %files -f %{name}-qt4.lang
@@ -82,6 +98,7 @@ grep %{_qt5_translationdir} %{name}.lang > %{name}-qt5.lang
 %{_includedir}/qtkeychain/
 %{_libdir}/cmake/QtKeychain/
 %{_libdir}/libqtkeychain.so
+%endif
 
 %ldconfig_scriptlets qt5

Comment 3 adam winberg 2020-05-29 07:45:24 UTC
any updates on this?

Comment 4 Troy Dawson 2020-05-29 14:01:50 UTC
I am volunteering to package and maintain this package in EPEL8.
Per the EPEL policy, if the maintainer doesn't respond back in a week (since this is the second time I've asked), I'll put a ticket in and will be made co-maintainer and be able to branch and build it in EPEL.

As a side note, I think this package should be maintained by the kde-sig.  Looking at the Fedora builds, it's been the kde-sig that has been maintaining it.

Comment 5 Mukundan Ragavan 2020-05-29 15:04:08 UTC
I can add you as a co-maintainer. No problem. I don't remember when I took this package but it was going to be orphaned and I needed it for one of packages.

What's your FAS?

Comment 6 Troy Dawson 2020-05-29 15:46:47 UTC
tdawson

Comment 7 Mukundan Ragavan 2020-05-29 15:49:33 UTC
I have added you. Also made you EPEL8 contact.

Comment 8 Mukundan Ragavan 2020-05-29 15:50:44 UTC
kde-sig is also now added.

Comment 9 Troy Dawson 2020-05-29 17:18:35 UTC
Thank You.
Since this ticket is for Fedora EPEL, I'll take it and start working on it.

Comment 10 Mukundan Ragavan 2020-05-29 20:45:07 UTC
Great. Thanks.

Comment 11 bugzilla 2020-07-01 06:28:15 UTC
Any news on this?

Comment 12 Troy Dawson 2020-07-01 13:46:40 UTC
Thank you for pinging me.  I honestly thought I'd done it, but as you obviously can see, I didn't.

I won't be able to get to it before the weekend, but I've put it on my list of packages to do then.
I should have it in epel-testing next week sometime.

Comment 13 Fedora Update System 2020-07-06 16:34:56 UTC
FEDORA-EPEL-2020-ea970ec00a has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-ea970ec00a

Comment 14 Fedora Update System 2020-07-07 01:30:05 UTC
FEDORA-EPEL-2020-ea970ec00a has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-ea970ec00a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2020-07-22 01:35:40 UTC
FEDORA-EPEL-2020-ea970ec00a has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.