Bug 1771145

Summary:	Review Request: perl-MooseX-Deprecated - Mark attributes and methods as deprecated
Product:	[Fedora] Fedora	Reporter:	Yanko Kaneti <yaneti>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-11-16 19:47:29 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Yanko Kaneti 2019-11-11 21:50:40 UTC

Spec URL: http://declera.com/~yaneti/perl-MooseX-Deprecated/perl-MooseX-Deprecated.spec
SRPM URL: http://declera.com/~yaneti/perl-MooseX-Deprecated/perl-MooseX-Deprecated-0.005-1.fc32.src.rpm
Description: MooseX::Deprecated is a parameterizable role that makes it easy to deprecate particular attributes and methods in a class.
Fedora Account System Username: yaneti

Comment 1 Jitka Plesnikova 2019-11-12 11:55:00 UTC

Source file is ok
Summary is ok

License 
FIX: COPYRIGHT and CREDITS are under license Public Domain (see COPYRIGHT: line 22)
     Change the license to '(GPL+ or Artistic) and Public Domain'

Description is ok
URL and Source0 are ok
All tests passed

BuildRequires 
FIX: Please add build-require 'make' used in spec file

$ rpm -qp --requires perl-MooseX-Deprecated-0.005-1.fc32.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Carp)
      1 perl(Devel::Callsite) >= 0.08
      1 perl(:MODULE_COMPAT_5.30.1)
      1 perl(MooseX::Role::Parameterized)
      1 perl(strict)
      1 perl(:VERSION) >= 5.8.3
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-MooseX-Deprecated-0.005-1.fc32.noarch.rpm | sort | uniq -c
      1 perl(MooseX::Deprecated) = 0.005
      1 perl-MooseX-Deprecated = 0.005-1.fc32
Binary provides are Ok.

$ rpmlint ./perl-MooseX-Deprecated*
perl-MooseX-Deprecated.noarch: W: spelling-error %description -l en_US parameterizable -> magnetizable
perl-MooseX-Deprecated.src: W: spelling-error %description -l en_US parameterizable -> magnetizable
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

Please correct all 'FIX' issues.

Resolution:
Approved

Comment 2 Gwyn Ciesla 2019-11-12 15:46:25 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-MooseX-Deprecated

Comment 3 Yanko Kaneti 2019-11-16 19:47:29 UTC

Imported. FIX-ed. Built for rawhide.

Thanks for the review.