Bug 1771145 - Review Request: perl-MooseX-Deprecated - Mark attributes and methods as deprecated
Summary: Review Request: perl-MooseX-Deprecated - Mark attributes and methods as depre...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-11-11 21:50 UTC by Yanko Kaneti
Modified: 2019-11-16 19:47 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-11-16 19:47:29 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Yanko Kaneti 2019-11-11 21:50:40 UTC
Spec URL: http://declera.com/~yaneti/perl-MooseX-Deprecated/perl-MooseX-Deprecated.spec
SRPM URL: http://declera.com/~yaneti/perl-MooseX-Deprecated/perl-MooseX-Deprecated-0.005-1.fc32.src.rpm
Description: MooseX::Deprecated is a parameterizable role that makes it easy to deprecate particular attributes and methods in a class.
Fedora Account System Username: yaneti

Comment 1 Jitka Plesnikova 2019-11-12 11:55:00 UTC
Source file is ok
Summary is ok

License 
FIX: COPYRIGHT and CREDITS are under license Public Domain (see COPYRIGHT: line 22)
     Change the license to '(GPL+ or Artistic) and Public Domain'

Description is ok
URL and Source0 are ok
All tests passed

BuildRequires 
FIX: Please add build-require 'make' used in spec file

$ rpm -qp --requires perl-MooseX-Deprecated-0.005-1.fc32.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Carp)
      1 perl(Devel::Callsite) >= 0.08
      1 perl(:MODULE_COMPAT_5.30.1)
      1 perl(MooseX::Role::Parameterized)
      1 perl(strict)
      1 perl(:VERSION) >= 5.8.3
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-MooseX-Deprecated-0.005-1.fc32.noarch.rpm | sort | uniq -c
      1 perl(MooseX::Deprecated) = 0.005
      1 perl-MooseX-Deprecated = 0.005-1.fc32
Binary provides are Ok.

$ rpmlint ./perl-MooseX-Deprecated*
perl-MooseX-Deprecated.noarch: W: spelling-error %description -l en_US parameterizable -> magnetizable
perl-MooseX-Deprecated.src: W: spelling-error %description -l en_US parameterizable -> magnetizable
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

Please correct all 'FIX' issues.

Resolution:
Approved

Comment 2 Gwyn Ciesla 2019-11-12 15:46:25 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-MooseX-Deprecated

Comment 3 Yanko Kaneti 2019-11-16 19:47:29 UTC
Imported. FIX-ed. Built for rawhide.

Thanks for the review.


Note You need to log in before you can comment on or make changes to this bug.