Bug 1771448

Summary: libglusterfs/gidcache.c : missing unlock
Product: [Community] GlusterFS Reporter: JinyuXi <xijinyu0811>
Component: coreAssignee: bugs <bugs>
Status: CLOSED NOTABUG QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-11-13 06:24:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description JinyuXi 2019-11-12 11:48:26 UTC 
Description of problem:

{
	LOCK(&cache->gc_lock);
	......
	for (i = 0; i < AUX_GID_CACHE_ASSOC; i++, agl++) {
		if (!agl->gl_list)
			continue;
		if (agl->gl_id != id)
			continue;

		if (agl->gl_uid != uid || agl->gl_gid != gid)
			break;

		if (now < agl->gl_deadline) {        //Missing unlock
			return agl;
		}
		break;
	}
	UNLOCK(&cache->gc_lock);
	return NULL;
}



How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 1 Worker Ant 2019-11-12 12:12:21 UTC 
REVIEW: https://review.gluster.org/23700 (libglusterfs/gidcache.c: missing unlock) posted (#1) for review on master by xijinyu