Bug 1771448 - libglusterfs/gidcache.c : missing unlock
Summary: libglusterfs/gidcache.c : missing unlock
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: GlusterFS
Classification: Community
Component: core
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-11-12 11:48 UTC by JinyuXi
Modified: 2019-11-13 06:24 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-11-13 06:24:30 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Gluster.org Gerrit 23700 0 None Abandoned libglusterfs/gidcache.c: missing unlock 2019-11-13 06:09:03 UTC

Description JinyuXi 2019-11-12 11:48:26 UTC
Description of problem:

{
	LOCK(&cache->gc_lock);
	......
	for (i = 0; i < AUX_GID_CACHE_ASSOC; i++, agl++) {
		if (!agl->gl_list)
			continue;
		if (agl->gl_id != id)
			continue;

		if (agl->gl_uid != uid || agl->gl_gid != gid)
			break;

		if (now < agl->gl_deadline) {        //Missing unlock
			return agl;
		}
		break;
	}
	UNLOCK(&cache->gc_lock);
	return NULL;
}



How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2019-11-12 12:12:21 UTC
REVIEW: https://review.gluster.org/23700 (libglusterfs/gidcache.c: missing unlock) posted (#1) for review on master by xijinyu


Note You need to log in before you can comment on or make changes to this bug.