Bug 1771584

Summary:	Rebase boom-boot to released upstream version 1.0
Product:	Red Hat Enterprise Linux 8	Reporter:	Bryn M. Reeves <bmr>
Component:	boom-boot	Assignee:	Marian Csontos <mcsontos>
Status:	CLOSED ERRATA	QA Contact:	cluster-qe <cluster-qe>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	8.1	CC:	agk, bmr, cmarthal, jbrassow, mcsontos, rhandlin
Target Milestone:	rc	Keywords:	Rebase
Target Release:	8.0
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	boom-boot-1.0-1.el8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-04-28 16:58:31 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Bryn M. Reeves 2019-11-12 16:28:25 UTC

This bug was initially created as a copy of Bug #1717853

I am copying this bug because: 
Boom was updated to a pre-release snapshot of boom-1.0 taken from master in June 2019: this is missing significant features and fixes that were not merged at that time, and that will be included in the actual boom-1.0 upstream release.

Request to rebase boom-boot to latest upstream version 1.0 soon to be released.

* The pre-release is already included in Rawhide,
* Red Hat is upstream,
* Lot of work driven by RHEL went to the tool.

Comment 6 Corey Marthaler 2020-03-31 03:43:07 UTC

One issue we found was the apparent missing functionality mentioned in comment #5 and filed bug 1819010 to track that separately.

Marking verified (SanityOnly) in the latest rpms.

boom-boot-1.0-1.el8    BUILT: Fri Nov 29 05:18:30 CST 2019


host-083: pvcreate  /dev/sdc1 /dev/sda1
host-083: vgcreate   snapper /dev/sdc1 /dev/sda1

Enabling dmeventd
============================================================
Iteration 1 of 1 started at Mon Mar 30 22:35:11 CDT 2020
============================================================
SCENARIO - [boom_sanity]
Create a snapshot and perform some boom sanity only checks as this wont be an actual bootable snapshot
Installing package boom-boot on host-083...
Package boom-boot installed on node host-083.
Making origin volume
lvcreate -L 300M snapper -n origin
Making snapshot of origin volume
lvcreate -s /dev/snapper/origin -c 128 -n boom_snap -L 100M

Check 0. Verify a new profile can be created
boom profile create --from-host --uname-pattern el8

Check 1. Verify boom not configured for grub yet warning (Bug 1542952)
boom create --title Title --root-device /dev/snapper/boom_snap

Generating grub configuration file ...
done

Check 2 a. Verify version numbers not matching an OS profile provide a helpful warning (Bug 1771584#c5)
boom create --title nomatchversion --rootlv snapper/boom_snap --version 2.5.0

Check 2 b. Verify fake OS profiles are properly identified (Bug 1540266)
boom create --profile fake_profile --title title --version 3.10-272.el7 --rootlv snapper/boom_snap
WARNING - Boom grub2 integration is disabled in '/boot/../etc/default/boom'

Check 3. Verify --rootlv and --root-device varations are both accepted (Bug 1543188)
--rootlv: boom create --title 1 --rootlv /dev/snapper/boom_snap
WARNING - Boom grub2 integration is disabled in '/boot/../etc/default/boom'
boom list 89d26a2
BootID  Version                  Name                     RootDevice            
89d26a2 4.18.0-192.el8.x86_64    Red Hat Enterprise Linux /dev/snapper/boom_snap
boom delete 89d26a2

--root-lv: boom create --title 2 --root-lv /dev/snapper/boom_snap
WARNING - Boom grub2 integration is disabled in '/boot/../etc/default/boom'
boom list 90e76eb
BootID  Version                  Name                     RootDevice            
90e76eb 4.18.0-192.el8.x86_64    Red Hat Enterprise Linux /dev/snapper/boom_snap
boom delete 90e76eb

--rootdevice: boom create --title 3 --rootdevice /dev/snapper/boom_snap
WARNING - Boom grub2 integration is disabled in '/boot/../etc/default/boom'
boom list 7f0cfb0
BootID  Version                  Name                     RootDevice            
7f0cfb0 4.18.0-192.el8.x86_64    Red Hat Enterprise Linux /dev/snapper/boom_snap
boom delete 7f0cfb0

--root-device: boom create --title 4 --root-device /dev/snapper/boom_snap
WARNING - Boom grub2 integration is disabled in '/boot/../etc/default/boom'
boom list bf8a432
BootID  Version                  Name                     RootDevice            
bf8a432 4.18.0-192.el8.x86_64    Red Hat Enterprise Linux /dev/snapper/boom_snap
boom delete bf8a432

Check 4. Verify --root-lv and --root-device verify the lv/device exists (Bug 1543186)
boom create --title no-lv --root-lv snapper/nonlv
WARNING - Boom grub2 integration is disabled in '/boot/../etc/default/boom'
boom create --title no-dev --root-device /dev/sdxyz
WARNING - Boom grub2 integration is disabled in '/boot/../etc/default/boom'
boom create --title 5 --no-dev --root-lv snapper/nonlv
WARNING - Boom grub2 integration is disabled in '/boot/../etc/default/boom'
boom delete 5b176cf

Check 5. Verify proper use of user providing --rootlv /dev/* format (Bug 1544914)
boom create --title 6 --rootlv /dev/snapper/boom_snap
WARNING - Boom grub2 integration is disabled in '/boot/../etc/default/boom'
Created entry with boot_id 9bf9017:
  title 6
  machine-id 40a6ef4b385f4d0694b9c11428e5c0dd
  version 4.18.0-192.el8.x86_64
  linux /vmlinuz-4.18.0-192.el8.x86_64
  initrd /initramfs-4.18.0-192.el8.x86_64.img
  options root=/dev/snapper/boom_snap ro rd.lvm.lv=snapper/boom_snap
boom delete 9bf9017

Check 6. Verify proper rd.lvm.lv entry w/ --root-device option (Also listed in Bug 1544914)
boom create --title 7 --root-device /dev/snapper/boom_snap
WARNING - Boom grub2 integration is disabled in '/boot/../etc/default/boom'
Created entry with boot_id 6024be3:
  title 7
  machine-id 40a6ef4b385f4d0694b9c11428e5c0dd
  version 4.18.0-192.el8.x86_64
  linux /vmlinuz-4.18.0-192.el8.x86_64
  initrd /initramfs-4.18.0-192.el8.x86_64.img
  options root=/dev/snapper/boom_snap ro rd.lvm.lv=snapper/boom_snap
boom delete 6024be3

First, splitting off snapshot volume before removal
lvconvert -f --splitsnapshot /dev/snapper/boom_snap
Removing volume snapper/boom_snap
Removing origin snapper/origin

Comment 8 errata-xmlrpc 2020-04-28 16:58:31 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:1876