Red Hat Bugzilla – Bug 1540266
boom should return non zero if OsProfile is invalid
Last modified: 2018-04-10 11:24:41 EDT
Description of problem: [root@host-083 ~]# lvs -a -o +devices snapper/snap1 LV VG Attr LSize Pool Origin Data% Meta% Move Log Cpy%Sync Convert Devices snap1 snapper swi-a-s--- 100.00m origin 0.00 /dev/sdg1(100) [root@host-083 ~]# boom create --profile fake_profile --title my_title --version 3.10-272.el7 --rootlv snapper/snap1 OsProfile not found: fake_profile [root@host-083 ~]# echo $? 0 Version-Release number of selected component (if applicable): 3.10.0-841.el7.x86_64 lvm2-2.02.177-1.el7 BUILT: Tue Jan 23 16:50:39 CET 2018 lvm2-libs-2.02.177-1.el7 BUILT: Tue Jan 23 16:50:39 CET 2018 lvm2-cluster-2.02.177-1.el7 BUILT: Tue Jan 23 16:50:39 CET 2018 lvm2-lockd-2.02.177-1.el7 BUILT: Tue Jan 23 16:50:39 CET 2018 lvm2-python-boom-0.8.2-1.el7 BUILT: Tue Jan 23 16:53:42 CET 2018 cmirror-2.02.177-1.el7 BUILT: Tue Jan 23 16:50:39 CET 2018 device-mapper-1.02.146-1.el7 BUILT: Tue Jan 23 16:50:39 CET 2018 device-mapper-libs-1.02.146-1.el7 BUILT: Tue Jan 23 16:50:39 CET 2018 device-mapper-event-1.02.146-1.el7 BUILT: Tue Jan 23 16:50:39 CET 2018 device-mapper-event-libs-1.02.146-1.el7 BUILT: Tue Jan 23 16:50:39 CET 2018 device-mapper-persistent-data-0.7.3-3.el7 BUILT: Tue Nov 14 12:07:18 CET 2017
In boom-0.8.3.
The fix in 0.8.3 ensures that the exit status is properly propagated (in Python this must use the sys.exit(status) call, rather than a simple return from main), and also adds a top-level exception catcher to print a readable summary of any unhandled exceptions (this may be disabled by enabling debug logging in order to obtain the full backtrace for debugging or bug filing).
Fix verified in the latest rpms. [root@host-082 ~]# boom create --profile fake_profile --title my_title --version 3.10-272.el7 --rootlv snapper/snap1 OsProfile not found: fake_profile [root@host-082 ~]# echo $? 1 3.10.0-847.el7.x86_64 lvm2-2.02.177-2.el7 BUILT: Wed Feb 7 17:39:26 CET 2018 lvm2-libs-2.02.177-2.el7 BUILT: Wed Feb 7 17:39:26 CET 2018 lvm2-cluster-2.02.177-2.el7 BUILT: Wed Feb 7 17:39:26 CET 2018 lvm2-lockd-2.02.177-2.el7 BUILT: Wed Feb 7 17:39:26 CET 2018 lvm2-python-boom-0.8.3-2.el7 BUILT: Wed Feb 7 17:42:09 CET 2018 cmirror-2.02.177-2.el7 BUILT: Wed Feb 7 17:39:26 CET 2018 device-mapper-1.02.146-2.el7 BUILT: Wed Feb 7 17:39:26 CET 2018 device-mapper-libs-1.02.146-2.el7 BUILT: Wed Feb 7 17:39:26 CET 2018 device-mapper-event-1.02.146-2.el7 BUILT: Wed Feb 7 17:39:26 CET 2018 device-mapper-event-libs-1.02.146-2.el7 BUILT: Wed Feb 7 17:39:26 CET 2018 device-mapper-persistent-data-0.7.3-3.el7 BUILT: Tue Nov 14 12:07:18 CET 2017
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2018:0853