Bug 177232

Summary:	Review Request: regionset - reads/sets the region code of DVD drives
Product:	[Fedora] Fedora	Reporter:	Dominik 'Rathann' Mierzejewski <dominik>
Component:	Package Review	Assignee:	John Mahowald <jpmahowald>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	gauret, jpmahowald
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-09-01 18:52:38 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Dominik 'Rathann' Mierzejewski 2006-01-08 00:13:27 UTC

Spec Name or Url: http://rpm.greysector.net/extras/regionset.spec
SRPM Name or Url: http://rpm.greysector.net/extras/regionset-0.1-1.src.rpm
Description: 
regionset will show you the current region code of the drive, how often it
has been changed and how many changes are left. If there are any changes
left, it asks for the new region code (see table above).

Comment 1 John Mahowald 2006-01-29 05:29:30 UTC

Not a review, but:

* Don't use Vendor: tag.
* Don't do the conditional %clean, just rm -rf $RPM_BUILD_ROOT. You set a sane
BuildRoot.
* "(see table above)" in %description doesn't make sense, probably from a
copy/paste.

Comment 2 Aurelien Bompard 2006-03-05 16:51:25 UTC

(just assigning to John and blocking FE-REVIEW)

Comment 3 Dominik 'Rathann' Mierzejewski 2006-04-02 19:29:52 UTC

Fixed in
http://rpm.greysector.net/extras/regionset-0.1-2.src.rpm
(spec address the same as above)

Comment 4 John Mahowald 2006-04-08 16:15:07 UTC

Almost there.

Still need macros instead of /usr/sbin in %install

Comment 5 Michael Schwendt 2006-05-29 11:23:30 UTC

Dropping FE-NEEDSPONSOR. Tom Callaway offered sponsorship in bug 177235
(and bugzilla change-several-bugs-at-once feature requires me to add/edit
something).

Comment 6 Michael Schwendt 2006-05-29 11:31:04 UTC

uhm, bugzilla is broken :(

Comment 7 Dominik 'Rathann' Mierzejewski 2006-07-28 19:21:09 UTC

Fixed those macros.

http://rpm.greysector.net/extras/regionset.spec
http://rpm.greysector.net/extras/regionset-0.1-3.src.rpm

Comment 8 Dominik 'Rathann' Mierzejewski 2006-08-08 11:41:33 UTC

*ping*

Comment 9 John Mahowald 2006-08-14 05:04:02 UTC

Needs work:
- Run rm -rf $RPM_BUILD_ROOT right after %install like the templates
- Need smp flags or comments why not

Good:
+ version-release
+ file permissions good
+ file ownership good
+ license (GPL)
+ sources match

Comment 10 Dominik 'Rathann' Mierzejewski 2006-08-15 04:20:05 UTC

http://rpm.greysector.net/extras/regionset.spec
http://rpm.greysector.net/extras/regionset-0.1-4.src.rpm

Fixed, although there really is no point in using smp flags, because there's
only one gcc command ever executed. Well, it doesn't hurt, either.

Comment 11 John Mahowald 2006-08-30 16:09:52 UTC

+ Follows naming conventions
+ proper %clean section
+ proper permissions
+ macro usage

APPROVED

Comment 12 Dominik 'Rathann' Mierzejewski 2006-09-01 18:52:38 UTC

Imported and built for devel. Thanks for the review!