Red Hat Bugzilla – Bug 177232
Review Request: regionset - reads/sets the region code of DVD drives
Last modified: 2007-11-30 17:11:20 EST
Spec Name or Url: http://rpm.greysector.net/extras/regionset.spec
SRPM Name or Url: http://rpm.greysector.net/extras/regionset-0.1-1.src.rpm
regionset will show you the current region code of the drive, how often it
has been changed and how many changes are left. If there are any changes
left, it asks for the new region code (see table above).
Not a review, but:
* Don't use Vendor: tag.
* Don't do the conditional %clean, just rm -rf $RPM_BUILD_ROOT. You set a sane
* "(see table above)" in %description doesn't make sense, probably from a
(just assigning to John and blocking FE-REVIEW)
(spec address the same as above)
Still need macros instead of /usr/sbin in %install
Dropping FE-NEEDSPONSOR. Tom Callaway offered sponsorship in bug 177235
(and bugzilla change-several-bugs-at-once feature requires me to add/edit
uhm, bugzilla is broken :(
Fixed those macros.
- Run rm -rf $RPM_BUILD_ROOT right after %install like the templates
- Need smp flags or comments why not
+ file permissions good
+ file ownership good
+ license (GPL)
+ sources match
Fixed, although there really is no point in using smp flags, because there's
only one gcc command ever executed. Well, it doesn't hurt, either.
+ Follows naming conventions
+ proper %clean section
+ proper permissions
+ macro usage
Imported and built for devel. Thanks for the review!