Bug 1774741
| Summary: | Review Request: bcftools - Tools for genomic variant calling and manipulating VCF/BCF files | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jun Aruga <jaruga> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jmarshall, package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | bcftools-1.9-1.fc32 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-12-12 01:06:47 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1131121 | ||
|
Description
Jun Aruga
2019-11-20 20:33:58 UTC
Hi I would like to package the bio tool: bcftools using htslib in samtools project. I did following tests. * mock build: ok * rpmlint check: ok * Install check: ok * Check on mock environment: ok * Scratch build: ok https://koji.fedoraproject.org/koji/taskinfo?taskID=38927483 Note I am using `ExcludeArch: s390x`, because it is not supported. https://fedoraproject.org/wiki/Architectures#ExcludeArch_.26_ExclusiveArch Someone, could review it? https://fedoraproject.org/wiki/Package_Review_Process > A reviewer takes on the task of reviewing your package. They will set the fedora-review flag to ? Thank you. > URL: http://www.htslib.org/ https:// works. > %{_bindir}/* Please don't use a wildcard. This often leads to problems when the name changes or something additional is installed. %{_bindir}/bcftools %{_bindir}/color-chrs.pl %{_bindir}/guess-ploidy.py %{_bindir}/plot-roh.py %{_bindir}/plot-vcfstats %{_bindir}/run-roh.pl %{_bindir}/vcfutils.pl rpmlint: bcftools.src: W: spelling-error Summary(en_US) genomic -> gnomic, ergonomic bcftools.src: W: spelling-error %description -l en_US genomic -> gnomic, ergonomic bcftools.src: W: spelling-error %description -l en_US polysomy -> polys bcftools.src: W: spelling-error %description -l en_US subcommand -> sub command, sub-command, commandant bcftools.x86_64: W: spelling-error Summary(en_US) genomic -> gnomic, ergonomic bcftools.x86_64: W: spelling-error %description -l en_US genomic -> gnomic, ergonomic bcftools.x86_64: W: spelling-error %description -l en_US polysomy -> polys bcftools.x86_64: W: spelling-error %description -l en_US subcommand -> sub command, sub-command, commandant bcftools.x86_64: W: no-manual-page-for-binary color-chrs.pl bcftools.x86_64: W: no-manual-page-for-binary guess-ploidy.py bcftools.x86_64: W: no-manual-page-for-binary plot-roh.py bcftools.x86_64: W: no-manual-page-for-binary plot-vcfstats bcftools.x86_64: W: no-manual-page-for-binary run-roh.pl bcftools.x86_64: W: no-manual-page-for-binary vcfutils.pl 4 packages and 0 specfiles checked; 0 errors, 14 warnings. → all bogus warnings. + package name is OK + latest version + license is acceptable for Fedora (GPLv2) + license is specified correctly + builds and installs OK Package is APPROVED. Please fix the issues listed above when importing. Hi Zbigniew, > Package is APPROVED. Please fix the issues listed above when importing. Sure. I really appreciate your help. I fixed your mentioned 2 points, and updated above Spec URL and SRPM URL just in case. Now waiting the repo will be created. ``` $ fedpkg request-repo bcftools 1774741 https://pagure.io/releng/fedora-scm-requests/issue/20170 ``` (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/bcftools FEDORA-2019-389d258c80 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-389d258c80 bcftools-1.9-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-309d17cf8d bcftools-1.9-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-389d258c80 bcftools-1.9-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. bcftools-1.9-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. FEDORA-EPEL-2020-1de4190a52 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-1de4190a52 FEDORA-EPEL-2020-f7b02980b0 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-f7b02980b0 FEDORA-EPEL-2020-1de4190a52 has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-1de4190a52 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2020-f7b02980b0 has been pushed to the Fedora EPEL 7 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-f7b02980b0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2020-1de4190a52 has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2020-f7b02980b0 has been pushed to the Fedora EPEL 7 stable repository. If problem still persists, please make note of it in this bug report. |