Bug 1775637

Summary:	Remove guest access by default for GlusterFS volume SMB shares added by hook scripts
Product:	[Red Hat Storage] Red Hat Gluster Storage	Reporter:	Anoop C S <anoopcs>
Component:	core	Assignee:	Anoop C S <anoopcs>
Status:	CLOSED ERRATA	QA Contact:	Aditya Ramteke <aramteke>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rhgs-3.5	CC:	bugs, dwalveka, pasik, pprakash, puebele, rhs-bugs, rhs-smb, rkothiya, sheggodu, storage-qa-internal, susgupta, vdas
Target Milestone:	---	Keywords:	ZStream
Target Release:	RHGS 3.5.z Batch Update 3
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-6.0-38	Doc Type:	Enhancement
Doc Text:	With this update, guest access to the newly created GlusterFS volume shares via SMB is not enabled by default.	Story Points:	---
Clone Of:	1775612	Environment:
Last Closed:	2020-12-17 04:50:17 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1775612, 1781483
Bug Blocks:

Description Anoop C S 2019-11-22 13:24:57 UTC

+++ This bug was initially created as a clone of Bug #1775612 +++

Description of problem:
SMB share section for GlusterFS volume added by Samba hook scripts with the help of user.smb/user.cifs volume set option currently has the following format:

[gluster-$VOLNAME]
comment = For samba share of volume $VOLNAME
vfs objects = glusterfs
glusterfs:volume = $VOLNAME
glusterfs:logfile = $LOGFILEBASE/glusterfs-$VOLNAME.%M.log
glusterfs:loglevel = 7
path = /
read only = no
guest ok = yes
kernel share modes = no

Allowing guest access with "guest ok = yes" is not a basic requirement and is purely an optional share parameter. Furthermore it could lead SMB client to attempt SMB requests out of a guest session resulting in minor issues from different use cases.

Version-Release number of selected component (if applicable):
master

--- Additional comment from Worker Ant on 2019-11-22 17:41:26 IST ---

REVIEW: https://review.gluster.org/23745 (extras/hooks: Remove smb.conf parameter allowing guest access) posted (#1) for review on master by Anoop C S

Comment 2 Vivek Das 2020-04-06 12:39:57 UTC

ACK for 3.5.2

Comment 15 errata-xmlrpc 2020-12-17 04:50:17 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (glusterfs bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:5603