Bug 1775612 - Remove guest access by default for GlusterFS volume SMB shares added by hook scripts
Summary: Remove guest access by default for GlusterFS volume SMB shares added by hook ...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: gluster-smb
Version: mainline
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Anoop C S
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1775637 1781483
TreeView+ depends on / blocked
 
Reported: 2019-11-22 12:05 UTC by Anoop C S
Modified: 2019-12-10 06:23 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1775637 1781483 (view as bug list)
Environment:
Last Closed: 2019-12-10 05:11:38 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:


Attachments (Terms of Use)


Links
System ID Priority Status Summary Last Updated
Gluster.org Gerrit 23745 None Merged extras/hooks: Remove smb.conf parameter allowing guest access 2019-12-10 05:11:37 UTC

Description Anoop C S 2019-11-22 12:05:51 UTC
Description of problem:
SMB share section for GlusterFS volume added by Samba hook scripts with the help of user.smb/user.cifs volume set option currently has the following format:

[gluster-$VOLNAME]
comment = For samba share of volume $VOLNAME
vfs objects = glusterfs
glusterfs:volume = $VOLNAME
glusterfs:logfile = $LOGFILEBASE/glusterfs-$VOLNAME.%M.log
glusterfs:loglevel = 7
path = /
read only = no
guest ok = yes
kernel share modes = no

Allowing guest access with "guest ok = yes" is not a basic requirement and is purely an optional share parameter. Furthermore it could lead SMB client to attempt SMB requests out of a guest session resulting in minor issues from different use cases.

Version-Release number of selected component (if applicable):
master

Comment 1 Worker Ant 2019-11-22 12:11:26 UTC
REVIEW: https://review.gluster.org/23745 (extras/hooks: Remove smb.conf parameter allowing guest access) posted (#1) for review on master by Anoop C S

Comment 2 Worker Ant 2019-12-10 05:11:38 UTC
REVIEW: https://review.gluster.org/23745 (extras/hooks: Remove smb.conf parameter allowing guest access) merged (#2) on master by Amar Tumballi


Note You need to log in before you can comment on or make changes to this bug.