Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1775612

Summary:	Remove guest access by default for GlusterFS volume SMB shares added by hook scripts
Product:	[Community] GlusterFS	Reporter:	Anoop C S <anoopcs>
Component:	gluster-smb	Assignee:	Anoop C S <anoopcs>
Status:	CLOSED NEXTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1775637 1781483 (view as bug list)		Environment:
Last Closed:	2019-12-10 05:11:38 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1775637, 1781483

Description Anoop C S 2019-11-22 12:05:51 UTC

Description of problem:
SMB share section for GlusterFS volume added by Samba hook scripts with the help of user.smb/user.cifs volume set option currently has the following format:

[gluster-$VOLNAME]
comment = For samba share of volume $VOLNAME
vfs objects = glusterfs
glusterfs:volume = $VOLNAME
glusterfs:logfile = $LOGFILEBASE/glusterfs-$VOLNAME.%M.log
glusterfs:loglevel = 7
path = /
read only = no
guest ok = yes
kernel share modes = no

Allowing guest access with "guest ok = yes" is not a basic requirement and is purely an optional share parameter. Furthermore it could lead SMB client to attempt SMB requests out of a guest session resulting in minor issues from different use cases.

Version-Release number of selected component (if applicable):
master

Comment 1 Worker Ant 2019-11-22 12:11:26 UTC

REVIEW: https://review.gluster.org/23745 (extras/hooks: Remove smb.conf parameter allowing guest access) posted (#1) for review on master by Anoop C S

Comment 2 Worker Ant 2019-12-10 05:11:38 UTC

REVIEW: https://review.gluster.org/23745 (extras/hooks: Remove smb.conf parameter allowing guest access) merged (#2) on master by Amar Tumballi