Bug 1776126

Summary: Review Request: rust-uom - Units of measurement
Product: [Fedora] Fedora Reporter: Artem <ego.cordatus>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <eclipseo>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: eclipseo, igor.raits, package-review
Target Milestone: ---Flags: eclipseo: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-12-13 18:03:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1776127    
Attachments:
Description Flags
Bump static_assertions to 1 none

Description Artem 2019-11-25 07:54:56 UTC 
Spec URL: https://copr-be.cloud.fedoraproject.org/results/atim/rust-crates/fedora-rawhide-x86_64/01117863-rust-uom/rust-uom.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/atim/rust-crates/fedora-rawhide-x86_64/01117863-rust-uom/rust-uom-0.26.0-1.fc32.src.rpm

Description:
Units of measurement is a crate that does automatic type-safe zero-cost
dimensional analysis. You can create your own systems or use the pre-built
International System of Units (SI) which is based on the International System
of Quantities (ISQ) and includes numerous quantities (length, mass, time, ...)
with conversion factors for even more numerous measurement units (meter,
kilometer, foot, mile, ...). No more crashing your climate orbiter!.

Fedora Account System Username: atim
Comment 1 Igor Raits 2019-12-07 12:40:46 UTC 
> # Initial patched metadata

No information what has been patched, why and links to the upstream.

> %bcond_with check

No information why this has been disabled, neither links to the upstream.
Comment 2 Artem 2019-12-07 20:24:41 UTC 
https://copr-be.cloud.fedoraproject.org/results/atim/rust-crates/fedora-rawhide-x86_64/01125953-rust-uom/rust-uom.spec

https://copr-be.cloud.fedoraproject.org/results/atim/rust-crates/fedora-rawhide-x86_64/01125953-rust-uom/rust-uom-0.26.0-2.fc32.src.rpm
Comment 3 Robert-André Mauchin 🐧 2019-12-11 20:15:59 UTC 
Created attachment 1644167 [details]
Bump static_assertions to 1

 - You need to detail what you have bumped:

# Initial patched metadata:
# * Bump quickcheck to 0.9.0 https://github.com/iliekturtles/uom/pull/171
# * Bump static_assertions to 1 https://github.com/iliekturtles/uom/pull/170

 - There is a breaking change going to static_assertions 1: you need to solve this! See patch I join. (Don't copy-paste, windows line endings ahoy)

 - Look Ma, tests passing:

test result: ok$<2>. 340 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
test result: ok$<2>. 119 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out
Comment 4 Artem 2019-12-12 15:09:40 UTC 
@eclipseo, awesome 😎👍🏻

Compiles fine with patch

https://copr-be.cloud.fedoraproject.org/results/atim/rust-crates/fedora-rawhide-x86_64/01128422-rust-uom/rust-uom.spec

https://copr-be.cloud.fedoraproject.org/results/atim/rust-crates/fedora-rawhide-x86_64/01128422-rust-uom/rust-uom-0.26.0-3.fc32.src.rpm
Comment 5 Robert-André Mauchin 🐧 2019-12-13 15:14:31 UTC 
Package approved.
Comment 6 Gwyn Ciesla 2019-12-13 15:48:34 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-uom