Bug 1776126 - Review Request: rust-uom - Units of measurement
Summary: Review Request: rust-uom - Units of measurement
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1776127
TreeView+ depends on / blocked
 
Reported: 2019-11-25 07:54 UTC by Artem
Modified: 2019-12-13 18:03 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-12-13 18:03:54 UTC
Type: Bug
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)
Bump static_assertions to 1 (4.58 KB, patch)
2019-12-11 20:15 UTC, Robert-André Mauchin 🐧
no flags Details | Diff

Description Artem 2019-11-25 07:54:56 UTC
Spec URL: https://copr-be.cloud.fedoraproject.org/results/atim/rust-crates/fedora-rawhide-x86_64/01117863-rust-uom/rust-uom.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/atim/rust-crates/fedora-rawhide-x86_64/01117863-rust-uom/rust-uom-0.26.0-1.fc32.src.rpm

Description:
Units of measurement is a crate that does automatic type-safe zero-cost
dimensional analysis. You can create your own systems or use the pre-built
International System of Units (SI) which is based on the International System
of Quantities (ISQ) and includes numerous quantities (length, mass, time, ...)
with conversion factors for even more numerous measurement units (meter,
kilometer, foot, mile, ...). No more crashing your climate orbiter!.

Fedora Account System Username: atim

Comment 1 Igor Raits 2019-12-07 12:40:46 UTC
> # Initial patched metadata

No information what has been patched, why and links to the upstream.

> %bcond_with check

No information why this has been disabled, neither links to the upstream.

Comment 3 Robert-André Mauchin 🐧 2019-12-11 20:15:59 UTC
Created attachment 1644167 [details]
Bump static_assertions to 1

 - You need to detail what you have bumped:

# Initial patched metadata:
# * Bump quickcheck to 0.9.0 https://github.com/iliekturtles/uom/pull/171
# * Bump static_assertions to 1 https://github.com/iliekturtles/uom/pull/170

 - There is a breaking change going to static_assertions 1: you need to solve this! See patch I join. (Don't copy-paste, windows line endings ahoy)

 - Look Ma, tests passing:

test result: ok$<2>. 340 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
test result: ok$<2>. 119 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out

Comment 5 Robert-André Mauchin 🐧 2019-12-13 15:14:31 UTC
Package approved.

Comment 6 Gwyn Ciesla 2019-12-13 15:48:34 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-uom


Note You need to log in before you can comment on or make changes to this bug.