Bug 177619
| Summary: | Review Request: python-nltk-lite: Python libraries and programs for natural language processing | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ignacio Vazquez-Abrams <ivazqueznet> |
| Component: | Package Review | Assignee: | Roozbeh Pournader <roozbeh> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | michel.salim |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-10-31 23:29:17 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
Ignacio Vazquez-Abrams
2006-01-12 13:03:37 UTC
Not a full review yet, but random suggestions for the beginning:
- The license file looks to be a stripped version of GPL, which is illegal to
redistribute, as GPL only allows verbatim copies. I suggest contacting upstream.
- Source0 should use %{version} instead of a hardcoded 0.6.1
- Don't use 'cp -ap' as '-a' also implies '-p': use either '-rp' or '-a' based
on the situation
- Remove the requirement on python-devel. it's not required to build the package.
- I get a warning during build:
/usr/lib/python2.4/site-packages/nltk_lite/parse/chunk.py:1247: SyntaxWarning:
import * only allowed at module level
- You should perhaps use 'install -d' instead of 'mkdir -p'
(In reply to comment #1) > Not a full review yet, but random suggestions for the beginning: > - The license file looks to be a stripped version of GPL, which is illegal to > redistribute, as GPL only allows verbatim copies. I suggest contacting upstream. I'm currently in contact with them. > - I get a warning during build: > /usr/lib/python2.4/site-packages/nltk_lite/parse/chunk.py:1247: SyntaxWarning: > import * only allowed at module level Bogus. > - You should perhaps use 'install -d' instead of 'mkdir -p' Not necessary. Updated. Updated. http://fedora.ivazquez.net/files/extras/python-nltk-lite.spec http://fedora.ivazquez.net/files/extras/python-nltk-lite-0.6.3-1.src.rpm (In reply to comment #4) > http://fedora.ivazquez.net/files/extras/python-nltk-lite-0.6.4-1.src.rpm Problems: * .pyo files are not %ghost-ed. * rpmlint gives me the following errors: E: python-nltk-lite non-executable-script /usr/lib/python2.4/site-packages/nltk_lite/tokenize/porter.py 0644 E: python-nltk-lite wrong-script-interpreter /usr/lib/python2.4/site-packages/nltk_lite/contrib/church.py "/usr/local/bin/python" E: python-nltk-lite non-executable-script /usr/lib/python2.4/site-packages/nltk_lite/contrib/church.py 0644 I just realized there is already a nltk_lite package. Ignacio, would you like me to hand over to you or can I take this package? I packaged nltk previously, before it was superceded by nltk_lite. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213192 Thanks, - Michel (In reply to comment #6) > I just realized there is already a nltk_lite package. Ignacio, would you like me > to hand over to you or can I take this package? I packaged nltk previously, > before it was superceded by nltk_lite. > > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213192 Ignacio hasn't been heard from for several months - see fedora-extras-list for August and September regarding what to do about his packages. I think that this bug needs to be closed as a dead review (see http://fedoraproject.org/wiki/Extras/Policy/StalledReviews) and you should proceed with your own submission. Sounds reasonable. I'll ask Roozbeh if he'd be kind enough to review that. |