Spec Name or Url: http://fedora.ivazquez.net/files/extras/python-nltk-lite.spec SRPM Name or Url: http://fedora.ivazquez.net/files/extras/python-nltk-lite-0.6.1-1.src.rpm Description: NLTK, the Natural Language Toolkit, is a suite of Python libraries and programs for symbolic and statistical natural language processing. This package contains a cut-down version of the data which contains only redistributable corpora.
Not a full review yet, but random suggestions for the beginning: - The license file looks to be a stripped version of GPL, which is illegal to redistribute, as GPL only allows verbatim copies. I suggest contacting upstream. - Source0 should use %{version} instead of a hardcoded 0.6.1 - Don't use 'cp -ap' as '-a' also implies '-p': use either '-rp' or '-a' based on the situation - Remove the requirement on python-devel. it's not required to build the package. - I get a warning during build: /usr/lib/python2.4/site-packages/nltk_lite/parse/chunk.py:1247: SyntaxWarning: import * only allowed at module level - You should perhaps use 'install -d' instead of 'mkdir -p'
(In reply to comment #1) > Not a full review yet, but random suggestions for the beginning: > - The license file looks to be a stripped version of GPL, which is illegal to > redistribute, as GPL only allows verbatim copies. I suggest contacting upstream. I'm currently in contact with them. > - I get a warning during build: > /usr/lib/python2.4/site-packages/nltk_lite/parse/chunk.py:1247: SyntaxWarning: > import * only allowed at module level Bogus. > - You should perhaps use 'install -d' instead of 'mkdir -p' Not necessary. Updated.
Updated. http://fedora.ivazquez.net/files/extras/python-nltk-lite.spec http://fedora.ivazquez.net/files/extras/python-nltk-lite-0.6.3-1.src.rpm
Updated. http://fedora.ivazquez.net/files/extras/python-nltk-lite-0.6.4-1.src.rpm
(In reply to comment #4) > http://fedora.ivazquez.net/files/extras/python-nltk-lite-0.6.4-1.src.rpm Problems: * .pyo files are not %ghost-ed. * rpmlint gives me the following errors: E: python-nltk-lite non-executable-script /usr/lib/python2.4/site-packages/nltk_lite/tokenize/porter.py 0644 E: python-nltk-lite wrong-script-interpreter /usr/lib/python2.4/site-packages/nltk_lite/contrib/church.py "/usr/local/bin/python" E: python-nltk-lite non-executable-script /usr/lib/python2.4/site-packages/nltk_lite/contrib/church.py 0644
I just realized there is already a nltk_lite package. Ignacio, would you like me to hand over to you or can I take this package? I packaged nltk previously, before it was superceded by nltk_lite. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213192 Thanks, - Michel
(In reply to comment #6) > I just realized there is already a nltk_lite package. Ignacio, would you like me > to hand over to you or can I take this package? I packaged nltk previously, > before it was superceded by nltk_lite. > > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213192 Ignacio hasn't been heard from for several months - see fedora-extras-list for August and September regarding what to do about his packages. I think that this bug needs to be closed as a dead review (see http://fedoraproject.org/wiki/Extras/Policy/StalledReviews) and you should proceed with your own submission.
Sounds reasonable. I'll ask Roozbeh if he'd be kind enough to review that.
*** This bug has been marked as a duplicate of 213192 ***