Bug 177619 - Review Request: python-nltk-lite: Python libraries and programs for natural language processing
Review Request: python-nltk-lite: Python libraries and programs for natural l...
Status: CLOSED DUPLICATE of bug 213192
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Roozbeh Pournader
Fedora Package Reviews List
:
Depends On:
Blocks: FE-DEADREVIEW
  Show dependency treegraph
 
Reported: 2006-01-12 08:03 EST by Ignacio Vazquez-Abrams
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2006-10-31 18:29:17 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Ignacio Vazquez-Abrams 2006-01-12 08:03:37 EST
Spec Name or Url: http://fedora.ivazquez.net/files/extras/python-nltk-lite.spec
SRPM Name or Url: http://fedora.ivazquez.net/files/extras/python-nltk-lite-0.6.1-1.src.rpm
Description: NLTK, the Natural Language Toolkit, is a suite of Python libraries and programs for symbolic and statistical natural language processing.

This package contains a cut-down version of the data which contains only redistributable corpora.
Comment 1 Roozbeh Pournader 2006-01-15 12:05:04 EST
Not a full review yet, but random suggestions for the beginning:
- The license file looks to be a stripped version of GPL, which is illegal to
redistribute, as GPL only allows verbatim copies. I suggest contacting upstream.
- Source0 should use %{version} instead of a hardcoded 0.6.1
- Don't use 'cp -ap' as '-a' also implies '-p': use either '-rp' or '-a' based
on the situation
- Remove the requirement on python-devel. it's not required to build the package.
- I get a warning during build:
/usr/lib/python2.4/site-packages/nltk_lite/parse/chunk.py:1247: SyntaxWarning:
import * only allowed at module level
- You should perhaps use 'install -d' instead of 'mkdir -p'
Comment 2 Ignacio Vazquez-Abrams 2006-01-22 01:39:19 EST
(In reply to comment #1)
> Not a full review yet, but random suggestions for the beginning:
> - The license file looks to be a stripped version of GPL, which is illegal to
> redistribute, as GPL only allows verbatim copies. I suggest contacting upstream.

I'm currently in contact with them.

> - I get a warning during build:
> /usr/lib/python2.4/site-packages/nltk_lite/parse/chunk.py:1247: SyntaxWarning:
> import * only allowed at module level

Bogus.

> - You should perhaps use 'install -d' instead of 'mkdir -p'

Not necessary.

Updated.
Comment 4 Ignacio Vazquez-Abrams 2006-04-27 03:32:00 EDT
Updated.

http://fedora.ivazquez.net/files/extras/python-nltk-lite-0.6.4-1.src.rpm
Comment 5 Roozbeh Pournader 2006-06-18 12:19:42 EDT
(In reply to comment #4)
> http://fedora.ivazquez.net/files/extras/python-nltk-lite-0.6.4-1.src.rpm

Problems:

* .pyo files are not %ghost-ed.

* rpmlint gives me the following errors:
E: python-nltk-lite non-executable-script
/usr/lib/python2.4/site-packages/nltk_lite/tokenize/porter.py 0644
E: python-nltk-lite wrong-script-interpreter
/usr/lib/python2.4/site-packages/nltk_lite/contrib/church.py "/usr/local/bin/python"
E: python-nltk-lite non-executable-script
/usr/lib/python2.4/site-packages/nltk_lite/contrib/church.py 0644
Comment 6 Michel Alexandre Salim 2006-10-31 10:59:44 EST
I just realized there is already a nltk_lite package. Ignacio, would you like me
to hand over to you or can I take this package? I packaged nltk previously,
before it was superceded by nltk_lite.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213192

Thanks,

- Michel
Comment 7 Paul Howarth 2006-10-31 11:24:43 EST
(In reply to comment #6)
> I just realized there is already a nltk_lite package. Ignacio, would you like me
> to hand over to you or can I take this package? I packaged nltk previously,
> before it was superceded by nltk_lite.
> 
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213192

Ignacio hasn't been heard from for several months - see fedora-extras-list for
August and September regarding what to do about his packages. I think that this
bug needs to be closed as a dead review (see
http://fedoraproject.org/wiki/Extras/Policy/StalledReviews) and you should
proceed with your own submission.
Comment 8 Michel Alexandre Salim 2006-10-31 18:29:17 EST
Sounds reasonable. I'll ask Roozbeh if he'd be kind enough to review that.
Comment 9 Michel Alexandre Salim 2006-11-09 11:03:14 EST

*** This bug has been marked as a duplicate of 213192 ***

Note You need to log in before you can comment on or make changes to this bug.