Bug 1776513

URL and Source0 addresses are Ok.
Source0 archive (SHA-256: 260e252f7367228c9b4e43ef50c0becb04c4781de660577b3086cc106c0028c0) is original. Ok.
Summary verified from lib/XString.pm. Ok.
Description verified from lib/XString.pm. Ok.
License verified from lib/XString.pm, t/00-load.t, t/cstring.t, Makefile.PL, XString.xs, LICENSE, and README. Ok.

TODO: Please constrain 'BuildRequires:  perl(ExtUtils::MakeMaker)' with '>= 6.76' due to the use of 'NO_PACKLIST=1 NO_PERLLOCAL=1'.
FIX: Build-require 'findutils' (perl-XString.spec:47).
TODO: Remove '>= 0.88' constrain from 'BuildRequires:  perl(Test::More)' because it's needed only for author tests that the spec file does not perform.
FIX: Either build-require 'perl(CPAN::Meta::Prereqs)' (t/00-report-prereqs.t:29) or do not build-require 'perl(CPAN::Meta)'. They are needed both for the optional tests.
FIX: Do not build-require unused 'perl(Test2::Bundle::Extended)', 'perl(Test2::Plugin::NoWarnings)', and 'perl(Test2::Tools::Explain)'.

Note: ./examples is not interesting.

All tests pass. Ok.

$ rpmlint perl-XString.spec ../SRPMS/perl-XString-0.002-1.fc32.src.rpm ../RPMS/x86_64/perl-XString-*
sh: /usr/bin/python2: No such file or directory
perl-XString.src: W: spelling-error %description -l en_US cstring -> string, c string, striking
perl-XString.src: W: spelling-error %description -l en_US perlstring -> stringer, stripling, sterling
perl-XString.x86_64: W: spelling-error %description -l en_US cstring -> string, c string, striking
perl-XString.x86_64: W: spelling-error %description -l en_US perlstring -> stringer, stripling, sterling
4 packages and 1 specfiles checked; 0 errors, 4 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/x86_64/perl-XString-0.002-1.fc32.x86_64.rpm 
drwxr-xr-x    2 root     root                        0 Nov 27 11:09 /usr/lib/.build-id
drwxr-xr-x    2 root     root                        0 Nov 27 11:09 /usr/lib/.build-id/ab
lrwxrwxrwx    1 root     root                       63 Nov 27 11:09 /usr/lib/.build-id/ab/c6644baecda4e2315bebf7bb520cdc01368454 -> ../../../../usr/lib64/perl5/vendor_perl/auto/XString/XString.so
-rw-r--r--    1 root     root                     1448 Aug 13 19:44 /usr/lib64/perl5/vendor_perl/XString.pm
drwxr-xr-x    2 root     root                        0 Nov 27 11:09 /usr/lib64/perl5/vendor_perl/auto/XString
-rwxr-xr-x    1 root     root                    15736 Nov 27 11:09 /usr/lib64/perl5/vendor_perl/auto/XString/XString.so
drwxr-xr-x    2 root     root                        0 Nov 27 11:09 /usr/share/doc/perl-XString
-rw-r--r--    1 root     root                      241 Aug 13 19:44 /usr/share/doc/perl-XString/Changes
-rw-r--r--    1 root     root                      358 Aug 13 19:44 /usr/share/doc/perl-XString/README
drwxr-xr-x    2 root     root                        0 Nov 27 11:09 /usr/share/licenses/perl-XString
-rw-r--r--    1 root     root                    18346 Aug 13 19:44 /usr/share/licenses/perl-XString/LICENSE
-rw-r--r--    1 root     root                     1623 Nov 27 11:09 /usr/share/man/man3/XString.3pm.gz
File permissions and layout are Ok.

$ rpm -q --requires -p ../RPMS/x86_64/perl-XString-0.002-1.fc32.x86_64.rpm | sort -f | uniq -c
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libperl.so.5.30()(64bit)
      1 libpthread.so.0()(64bit)
      1 libpthread.so.0(GLIBC_2.2.5)(64bit)
      1 perl(:MODULE_COMPAT_5.30.1)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
      1 rtld(GNU_HASH)
FIX: Run-require 'perl(XSLoader)' (lib/XString.pm:11). This one is not autodetected because of an indentation.

$ rpm -q --provides -p ../RPMS/x86_64/perl-XString-0.002-1.fc32.x86_64.rpm | sort -f | uniq -c
      1 perl(XString) = 0.002
      1 perl-XString = 0.002-1.fc32
      1 perl-XString(x86-64) = 0.002-1.fc32
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/x86_64/perl-XString-0.002-1.fc32.x86_64.rpm 
Binary dependencies are resolvable. Ok.

The package builds in Fedora 32 (https://koji.fedoraproject.org/koji/taskinfo?taskID=39374237). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.

Please correct the 'FIX' items and consider fixing 'TODO' items before building this pacakge.
Resolution: Pacakge APPROVED.

Hi Petr,

In reply to Petr Pisar from comment #1)
> TODO: Please constrain 'BuildRequires:  perl(ExtUtils::MakeMaker)' with '>=
> 6.76' due to the use of 'NO_PACKLIST=1 NO_PERLLOCAL=1'.

OK.

> FIX: Build-require 'findutils' (perl-XString.spec:47).

OK.

> TODO: Remove '>= 0.88' constrain from 'BuildRequires:  perl(Test::More)'
> because it's needed only for author tests that the spec file does not
> perform.

That version is needed by t/cstring.t, which uses done_testing but upstream hasn't put the versioned use of Test::More in that file.

> FIX: Either build-require 'perl(CPAN::Meta::Prereqs)'
> (t/00-report-prereqs.t:29) or do not build-require 'perl(CPAN::Meta)'. They
> are needed both for the optional tests.

OK.

> FIX: Do not build-require unused 'perl(Test2::Bundle::Extended)',
> 'perl(Test2::Plugin::NoWarnings)', and 'perl(Test2::Tools::Explain)'.

I put those in because the test suite complains quite loudly about them being missing. I raised https://github.com/atoomic/XString/issues/2 for upstream to get rid of them.

> $ rpm -q --requires -p ../RPMS/x86_64/perl-XString-0.002-1.fc32.x86_64.rpm |
> sort -f | uniq -c
>       1 libc.so.6()(64bit)
>       1 libc.so.6(GLIBC_2.2.5)(64bit)
>       1 libc.so.6(GLIBC_2.4)(64bit)
>       1 libperl.so.5.30()(64bit)
>       1 libpthread.so.0()(64bit)
>       1 libpthread.so.0(GLIBC_2.2.5)(64bit)
>       1 perl(:MODULE_COMPAT_5.30.1)
>       1 perl(strict)
>       1 perl(warnings)
>       1 rpmlib(CompressedFileNames) <= 3.0.4-1
>       1 rpmlib(FileDigests) <= 4.6.0-1
>       1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
>       1 rpmlib(PayloadIsZstd) <= 5.4.18-1
>       1 rtld(GNU_HASH)
> FIX: Run-require 'perl(XSLoader)' (lib/XString.pm:11). This one is not
> autodetected because of an indentation.

OK.

> Please correct the 'FIX' items and consider fixing 'TODO' items before
> building this pacakge.
> Resolution: Pacakge APPROVED.

Thanks for the review.

Repo and branch requests:

$ fedpkg request-repo perl-XString 1776513
https://pagure.io/releng/fedora-scm-requests/issue/20112

$ fedpkg request-branch --repo perl-XString f31
https://pagure.io/releng/fedora-scm-requests/issue/20113

$ fedpkg request-branch --repo perl-XString f30
https://pagure.io/releng/fedora-scm-requests/issue/20114

$ fedpkg request-branch --repo perl-XString epel8
https://pagure.io/releng/fedora-scm-requests/issue/20115
https://pagure.io/releng/fedora-scm-requests/issue/20116

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-XString

Fedora 29 changed to end-of-life (EOL) status on 2019-11-26. Fedora 29 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

This bug was accidentally closed due to a query error. Reopening.

FEDORA-EPEL-2019-ff1b06d3b8 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-ff1b06d3b8

FEDORA-2019-e2a5d0cf6e has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-e2a5d0cf6e

FEDORA-2019-7a62017650 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-7a62017650

perl-XString-0.002-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-7a62017650

perl-XString-0.002-2.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-e2a5d0cf6e

perl-XString-0.002-2.el8 has been pushed to the Fedora EPEL 8 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-ff1b06d3b8

perl-XString-0.002-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

perl-XString-0.002-2.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.

perl-XString-0.002-2.el8 has been pushed to the Fedora EPEL 8 stable repository. If problems still persist, please make note of it in this bug report.