Bug 1776509 - Review Request: perl-Test2-Tools-Explain - Explain tools for Perl's Test2 framework
Summary: Review Request: perl-Test2-Tools-Explain - Explain tools for Perl's Test2 fra...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1776513
TreeView+ depends on / blocked
 
Reported: 2019-11-25 20:40 UTC by Paul Howarth
Modified: 2019-12-13 00:11 UTC (History)
2 users (show)

Fixed In Version: perl-Test2-Tools-Explain-0.02-2.fc32
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-12-06 05:43:52 UTC
Type: ---
Embargoed:
ppisar: fedora-review+


Attachments (Terms of Use)

Description Paul Howarth 2019-11-25 20:40:28 UTC
Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Test2-Tools-Explain/branches/fedora/perl-Test2-Tools-Explain.spec

SRPM URL: http://www.city-fan.org/~paul/extras/perl-Test2-Tools-Explain/perl-Test2-Tools-Explain-0.02-1.fc32.src.rpm

Description:
Test2::Suite dropped the explain() function that had been part of Test::More.
For those who miss it in Test2, you can use Test2::Tools::Explain.


Fedora Account System Username: pghmcfc

This package is wanted by perl-XString.

Comment 1 Petr Pisar 2019-11-26 08:34:08 UTC
URL and Source0 addresses are Ok.
Source0 archive (SHA-256: e476bd1739e68f418617c308c3c3cf742de6a595c23bbac2c270e14159f73122) is original. Ok.
Summary verified from lib/Test2/Tools/Explain.pm. Ok

TODO: Rephrase the summary from "Perl's Test2 framework" to "Perl Test2 framework" or "Test2 framework of Perl". In my humble English knowledge possessive nouns cannot be used for languages.

Description: Verified from lib/Test2/Tools/Explain.pm. Ok.
License verified from lib/Test2/Tools/Explain.pm. Ok.

TODO: Build-require 'perl(:VERSION) >= 5.8.1' (Makefile.PL:1).

All tests pass. Ok.

$ rpmlint perl-Test2-Tools-Explain.spec ../SRPMS/perl-Test2-Tools-Explain-0.02-1.fc32.src.rpm ../RPMS/noarch/perl-Test2-Tools-Explain-0.02-1.fc32.noarch.rpm 
sh: /usr/bin/python2: No such file or directory
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Test2-Tools-Explain-0.02-1.fc32.noarch.rpm
drwxr-xr-x    2 root     root                        0 Nov 26 09:26 /usr/share/doc/perl-Test2-Tools-Explain
-rw-r--r--    1 root     root                      210 Oct  4  2016 /usr/share/doc/perl-Test2-Tools-Explain/Changes
-rw-r--r--    1 root     root                      441 Oct  4  2016 /usr/share/doc/perl-Test2-Tools-Explain/README.md
-rw-r--r--    1 root     root                     2989 Nov 26 09:26 /usr/share/man/man3/Test2::Tools::Explain.3pm.gz
drwxr-xr-x    2 root     root                        0 Nov 26 09:26 /usr/share/perl5/vendor_perl/Test2
drwxr-xr-x    2 root     root                        0 Nov 26 09:26 /usr/share/perl5/vendor_perl/Test2/Tools
-rw-r--r--    1 root     root                     4358 Oct  4  2016 /usr/share/perl5/vendor_perl/Test2/Tools/Explain.pm
File permissions and layout is Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Test2-Tools-Explain-0.02-1.fc32.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.30.1)
      1 perl(:VERSION) >= 5.8.1
      1 perl(Data::Dumper)
      1 perl(Exporter)
      1 perl(parent)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Test2-Tools-Explain-0.02-1.fc32.noarch.rpm | sort -f | uniq -c
      1 perl(Test2::Tools::Explain) = 0.02
      1 perl-Test2-Tools-Explain = 0.02-1.fc32
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Test2-Tools-Explain-0.02-1.fc32.noarch.rpm 
Binary dependencies are resolvable. Ok.

The package builds in F32 (https://koji.fedoraproject.org/koji/taskinfo?taskID=39353916). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.
Please consider fixing the 'TODO' items before building this package.
Resolution: Package APPROVED.

Comment 2 Paul Howarth 2019-11-26 09:15:47 UTC
Thanks Petr.

As a native English speaker I don't have a problem with "Perl's Test2 framework" (and clearly neither does upstream) but I'll change it to "the Perl Test2 framework" for clarity.

I considered the perl(:VERSION) requirement but since even EL4 had a recent enough perl I though it redundant these days. I can add it back in for completeness though.

Repo and branch requests:

$ fedpkg request-repo perl-Test2-Tools-Explain 1776509
https://pagure.io/releng/fedora-scm-requests/issue/20014

$ fedpkg request-branch --repo perl-Test2-Tools-Explain epel8
https://pagure.io/releng/fedora-scm-requests/issue/20015
https://pagure.io/releng/fedora-scm-requests/issue/20016

$ fedpkg request-branch --repo perl-Test2-Tools-Explain f31
https://pagure.io/releng/fedora-scm-requests/issue/20017

$ fedpkg request-branch --repo perl-Test2-Tools-Explain f30
https://pagure.io/releng/fedora-scm-requests/issue/20018

Comment 3 Igor Raits 2019-11-26 10:14:52 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Test2-Tools-Explain

Comment 4 Paul Howarth 2019-11-26 10:24:27 UTC
BuildError: package perl-Test2-Tools-Explain not in list for tag f32-updates-candidate

I guess I'll have to wait a bit.

Comment 5 Fedora Update System 2019-11-27 09:39:41 UTC
FEDORA-EPEL-2019-fd2c63f30c has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-fd2c63f30c

Comment 6 Fedora Update System 2019-11-27 09:39:42 UTC
FEDORA-2019-955d0a0b9e has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-955d0a0b9e

Comment 7 Ben Cotton 2019-11-27 14:19:49 UTC
Fedora 29 changed to end-of-life (EOL) status on 2019-11-26. Fedora 29 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 8 Fedora Update System 2019-11-28 00:41:23 UTC
perl-Test2-Tools-Explain-0.02-2.el8 has been pushed to the Fedora EPEL 8 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-fd2c63f30c

Comment 9 Fedora Update System 2019-11-28 01:44:22 UTC
perl-Test2-Tools-Explain-0.02-2.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-955d0a0b9e

Comment 10 Fedora Update System 2019-11-28 02:21:31 UTC
perl-Test2-Tools-Explain-0.02-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-fdd5f48e16

Comment 11 Fedora Update System 2019-12-06 05:43:52 UTC
perl-Test2-Tools-Explain-0.02-2.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2019-12-07 01:30:21 UTC
perl-Test2-Tools-Explain-0.02-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2019-12-13 00:11:02 UTC
perl-Test2-Tools-Explain-0.02-2.el8 has been pushed to the Fedora EPEL 8 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.