Bug 1776755

Summary: Package python-testtools for EPEL8
Product: [Fedora] Fedora EPEL Reporter: Jamie Lennox <jamielennox>
Component: python-testtoolsAssignee: Carl George 🤠 <carl>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: epel8CC: carl, clime7, jpena, kumarpraveen.nitdgp, michel, ramkrsna
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-testtools-2.4.0-3.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-05-12 02:13:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1815828, 1822409    
Bug Blocks: 1759112, 1815701, 1815830, 1815832, 1822780    

Description Jamie Lennox 2019-11-26 10:29:32 UTC
Please package for epel 8.

Comment 1 Michel Lind 2020-03-04 00:41:55 UTC
Jamie, is this still needed? I noticed python3-requests-mock is built in December.

python-testtools has not been released since 2017 and I'd rather not support it on a long-lived release unless it's absolutely required (and if so I'm happy to make you the maintainer for that branch)

Comment 2 Jamie Lennox 2020-03-04 02:14:36 UTC
I built requests-mock by disabling the unit tests in epel8/python3. So not needed by that bug any more, but it would be nice to have.

It's not valuable enough to me to maintain it (I got down to just maintaining packages for my own projects), however the entire openstack unit testing frameworks are built on testtools so I would have expected them to want it?

If I'm the only requestor you can close it out and I'll have a look if I need to migrate upstream.

Comment 3 Javier Peña 2020-04-01 16:36:59 UTC
It would be great if we could get an EPEL8 build for the package. I'm trying to build python-fixtures there, and it's failing due to this.

Comment 4 Michel Lind 2020-04-03 23:08:26 UTC
*** Bug 1815831 has been marked as a duplicate of this bug. ***

Comment 5 Michel Lind 2020-04-03 23:11:43 UTC
EPEL8 branch requested
https://pagure.io/releng/fedora-scm-requests/issue/24085
https://pagure.io/releng/fedora-scm-requests/issue/24086

Also, would anyone be interested in co-maintaining this? I don't really use it anymore and it seems better to have the maintainers who need it be unblocked if they need the package updated.

Comment 6 Carl George 🤠 2020-04-12 07:22:10 UTC
Michel, if you add the python-sig group myself and others in the SIG would be happy to assist.

Comment 7 Michel Lind 2020-04-24 02:24:22 UTC
(In reply to Carl George from comment #6)
> Michel, if you add the python-sig group myself and others in the SIG would
> be happy to assist.

Thanks Carl. python-sig added to the ACL.

Looks like python-extras will be stable tomorrow, and python-mimeparse in 4 days, so we should finally be able to build this package!

Comment 8 Carl George 🤠 2020-04-24 07:21:27 UTC
I figured this out, we had a build loop to overcome.  I've added comments directly in the spec file to make it more clear for future maintainers.

https://src.fedoraproject.org/rpms/python-testtools/c/f0ca163033077e93b309ec07953dbb6e0496fa6f?branch=master

I've got step 1 of that in an override, and I'm working through the other steps.

FYI Michel, when branching a package for EPEL it is discouraged to wipe out the changelog.  I reverted that commit to restore it.  I also did a merge with master so future master commits can be applied to the epel8 branch with a fast-forward.

Comment 9 Michel Lind 2020-04-24 23:48:14 UTC
Carl: good to know! I have another package I'm bringing to EPEL and I'll make sure the changelog is preserved for it. Also thanks for working on this.

Comment 10 Fedora Update System 2020-04-26 20:00:34 UTC
FEDORA-EPEL-2020-4c8aca531a has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-4c8aca531a

Comment 11 clime7 2020-04-26 20:02:34 UTC
Nice work, guys! Thank you.

Comment 12 Fedora Update System 2020-04-27 06:13:55 UTC
FEDORA-EPEL-2020-4c8aca531a has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-4c8aca531a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Michel Lind 2020-04-30 00:37:46 UTC
(In reply to Carl George from comment #8)
> I figured this out, we had a build loop to overcome.  I've added comments
> directly in the spec file to make it more clear for future maintainers.
> 
> https://src.fedoraproject.org/rpms/python-testtools/c/
> f0ca163033077e93b309ec07953dbb6e0496fa6f?branch=master
> 
> I've got step 1 of that in an override, and I'm working through the other
> steps.
> 
> FYI Michel, when branching a package for EPEL it is discouraged to wipe out
> the changelog.  I reverted that commit to restore it.  I also did a merge
> with master so future master commits can be applied to the epel8 branch with
> a fast-forward.

Carl, looks like python-testscenarios (which you also branch and build for bootstrapping python-testtools) somehow never has the epel8-playground branch created, and also appears to share all its commits with its master branch -- not sure how that happens?

And with package.cfg missing from python-testtools, the epel8-playground packages never got bootstrapped. If it's alright with you I'll try and recover them.

Comment 14 Carl George 🤠 2020-04-30 01:37:42 UTC
That branch wasn't created because I submitted the request with `--no-git-branch`, which authorizes the branch to be created but doesn't create it for you.  This also avoids creating the pacakge.cfg file.  This was intentional, as not every packager wants to deal with epel8-playground.  If you want to do it, you can create an epel8-playground locally and push it.

    git checkout epel8
    git pull
    git checkout -b epel8-playground
    git push -u origin epel8-playground

Comment 15 Fedora Update System 2020-05-12 02:13:36 UTC
FEDORA-EPEL-2020-4c8aca531a has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.