Bug 1781848

Summary:	Shard - code cleaning
Product:	[Community] GlusterFS	Reporter:	Barak Sason Rofman <bsasonro>
Component:	sharding	Assignee:	Barak Sason Rofman <bsasonro>
Status:	CLOSED NOTABUG	QA Contact:	bugs <bugs>
Severity:	medium	Docs Contact:
Priority:	low
Version:	mainline	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-01-13 10:02:03 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Barak Sason Rofman 2019-12-10 17:20:42 UTC

Description of problem:
- Numerous methods defined in a larger scope than needed.
- Methods return a value that is not used.
- Code duplication in several methods.
- Unused include.

Comment 1 Worker Ant 2019-12-10 17:25:25 UTC

REVIEW: https://review.gluster.org/23852 (Sharding - code cleaning) posted (#1) for review on master by Barak Sason Rofman

Comment 2 Barak Sason Rofman 2020-01-13 10:02:03 UTC

This issue should go under https://bugzilla.redhat.com/show_bug.cgi?id=1193929.
Closing this.