Bug 1781848 - Shard - code cleaning
Summary: Shard - code cleaning
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: GlusterFS
Classification: Community
Component: sharding
Version: mainline
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: ---
Assignee: Barak Sason Rofman
QA Contact: bugs@gluster.org
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-12-10 17:20 UTC by Barak Sason Rofman
Modified: 2020-01-13 10:02 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-01-13 10:02:03 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Gluster.org Gerrit 23852 0 None Abandoned Sharding - code cleaning 2019-12-15 13:22:22 UTC

Description Barak Sason Rofman 2019-12-10 17:20:42 UTC
Description of problem:
- Numerous methods defined in a larger scope than needed.
- Methods return a value that is not used.
- Code duplication in several methods.
- Unused include.

Comment 1 Worker Ant 2019-12-10 17:25:25 UTC
REVIEW: https://review.gluster.org/23852 (Sharding - code cleaning) posted (#1) for review on master by Barak Sason Rofman

Comment 2 Barak Sason Rofman 2020-01-13 10:02:03 UTC
This issue should go under https://bugzilla.redhat.com/show_bug.cgi?id=1193929.
Closing this.


Note You need to log in before you can comment on or make changes to this bug.