Bug 1783014

Summary:	OLM Unit Tests will not run
Product:	OpenShift Container Platform	Reporter:	Alexander Greene <agreene>
Component:	OLM	Assignee:	Alexander Greene <agreene>
OLM sub component:	OLM	QA Contact:	Bruno Andrade <bandrade>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	unspecified
Priority:	unspecified	CC:	scolange, tbuskey
Version:	4.4	Keywords:	Reopened
Target Milestone:	---
Target Release:	4.4.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-05-13 21:55:06 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1783011

Description Alexander Greene 2019-12-12 19:47:06 UTC

This bug was initially created as a copy of Bug #1783011

I am copying this bug because: 
The 4.3 bug requires a 4.4 bug.


Description of problem:
The base golang image that OLM is built from was recently updated to include the following Environment Variable: GOFLAGS="-mod=vendor".

OLM always sets "mod=venodr" in our go commands. As a result, the flag is set twice and OLM unit tests will always fail.

Version-Release number of selected component (if applicable): 4.3.0


How reproducible: Always


Steps to Reproduce:
1. Create a PR against the release-4.3

Actual results: Unit tests will not run


Expected results: Unit tests run

Comment 1 Alexander Greene 2019-12-12 19:48:30 UTC

This was already fixed in https://github.com/operator-framework/operator-lifecycle-manager/pull/1175

Closing this.

Comment 2 Alexander Greene 2019-12-12 20:05:54 UTC

I need this reviewed by QA.

Comment 3 Bruno Andrade 2019-12-13 17:45:01 UTC

Created PR https://github.com/operator-framework/operator-lifecycle-manager/pull/1199 fo release-4.4 branch and ci/prow/e2e-aws-console-olm, ci/prow/e2e-aws-olm were executed successfully.

Marking as VERIFIED.

Comment 5 errata-xmlrpc 2020-05-13 21:55:06 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0581