Bug 178311

Summary:	unallowed \r escape sequence
Product:	[Fedora] Fedora	Reporter:	Josep Puigdemont <jopu>
Component:	diskdumputils	Assignee:	Akira Imamura <aimamura>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	anderson, ktokunag, lwang, ntachino
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-02-24 20:07:32 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Josep Puigdemont 2006-01-19 11:55:00 UTC

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050921 Red Hat/1.0.7-1.4.1 Firefox/1.0.7

Description of problem:
There is a message in intscripts (diskdump) that contains a non recommended escape sequence '\r':

#: /etc/rc.d/init.d/diskdump:250
msgid "Saving panic dump from swap partition:\r"

gettext tools complain that:
"internationalized messages should not contain the `\r' escape sequence"

'\r' should probably be replaced by '\n'.


Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
Look at /etc/rc.d/init.d/diskdump line 250

Actual Results:  '\r' escape sequence found

Expected Results:  '\n' escape sequence expected

Additional info:

Comment 1 Dave Anderson 2006-01-20 14:17:27 UTC


I presume that the "\r" usage was done intentionally, and that 
the subsequent $SAVECORE command output is supposed to over-write
the "Saving panic..." string: 

swapsavecore() {
        for dev in $(echo $DEVICE | tr ':' ' '); do
                $DISKDUMPFMT -c $dev 2> /dev/null
                if [ $? -eq 6 ]; then
                        echo -e $"Saving panic dump from swap partition:\r" >&2
                        $SAVECORE -D -p $dev
                        RETVAL=$?
                        echo -ne "\r" >&2
                fi
        done
}

Comment 2 Akira Imamura 2006-02-01 23:51:42 UTC

As Dave said, the "\r" usage was done intentionally. It is required so as to show
a progress bar of savecore appropriately. If not "\r" but "\n" is used as
an escape sequence, then users see the following messages.

Saving panic dump from swap partition:
                                      ###############

Comment 3 Akira Imamura 2006-02-16 16:52:39 UTC

Although the diskdumputils package is included in FC, diskdump facility
isn't included in FC's kernel. Consequently, if this bug is for FC, then
I won't fix anything because diskdump doesn't work with FC due to the above
reason. I don't think anyone could see the message which was written in
comment #2.

Regards,
Akira

Comment 4 Akira Imamura 2006-02-24 20:07:32 UTC

I won't fix anything due to the following reasons, so I close this BZ.
- Although this does not affect to anything, many modifications will
  be required.