Bug 1784420
| Summary: | Review Request: rust-coreos-installer - Installer for Fedora CoreOS and RHEL CoreOS | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Robert Fairley <rfairley> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dustymabe, eclipseo, miabbott, package-review |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-12-21 10:21:09 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Robert Fairley
2019-12-17 11:56:56 UTC
Updated the description in the specfile to: ``` coreos-installer installs Fedora CoreOS or RHEL CoreOS to bare-metal machines (or, occasionally, to virtual machines). ``` - updated the specfile, SRPM accordingly at the above links. - You need to add a comment above the patch explaining the changes you've done.
- I don't think that is necessary:
Obsoletes: coreos-installer < 0.0.1
- You probably need a Provides along the coreos-installer-dracut Obsoletes
Provides: coreos-installer-dracut = %{version}-%{release}
- License ok
- Latest version packaged
- Builds in mock
- Conforms to Packaging Guidelines
(In reply to Robert-André Mauchin from comment #2) > - I don't think that is necessary: > > Obsoletes: coreos-installer < 0.0.1 Why is this not necessary? (In reply to Dusty Mabe from comment #3) > (In reply to Robert-André Mauchin from comment #2) > > - I don't think that is necessary: > > > > Obsoletes: coreos-installer < 0.0.1 > > Why is this not necessary? I think I see. It's not necessary because this `rust-coreos-installer` source package creates a `coreos-installer` subpackage and that will have a higher version so the old one will get obsoleted anyway. (In reply to Dusty Mabe from comment #3) > (In reply to Robert-André Mauchin from comment #2) > > - I don't think that is necessary: > > > > Obsoletes: coreos-installer < 0.0.1 > > Why is this not necessary? This is the same package name with a newer Version-Release, it will automatically supersede coreos-installer < 0.0.1 (In reply to Robert-André Mauchin from comment #2) > - You need to add a comment above the patch explaining the changes you've > done. > Added a comment in the specfile, and also uploaded a diff (sorry, did not upload the diff before): https://rfairley.fedorapeople.org/package-review/rust-coreos-installer-2/coreos-installer-fix-metadata.diff > - I don't think that is necessary: > > Obsoletes: coreos-installer < 0.0.1 > Removed this - makes sense. Added a comment noting why this is removed. > - You probably need a Provides along the coreos-installer-dracut Obsoletes > > Provides: coreos-installer-dracut = %{version}-%{release} > Since the dracut modules will not be included in this package, and will soon be replaced by https://github.com/coreos/coreos-installer/pull/100, I've left the `Provides` out. The `Obsoletes` should be sufficient here. I also updated the specfile for the 0.1.1 version - released recently. Updated specfile and SRPM: Spec URL: https://rfairley.fedorapeople.org/package-review/rust-coreos-installer-2/rust-coreos-installer.spec SRPM URL: https://rfairley.fedorapeople.org/package-review/rust-coreos-installer-2/rust-coreos-installer-0.1.1-1.fc32.src.rpm LGTM, package approved. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-coreos-installer Thank you for reviewing! |