Spec URL: https://rfairley.fedorapeople.org/package-review/rust-coreos-installer.spec SRPM URL: https://rfairley.fedorapeople.org/package-review/rust-coreos-installer-0.1.0-1.fc32.src.rpm Description: Installer for Fedora CoreOS and RHEL CoreOS. Fedora Account System Username: rfairley This renames the current `coreos-installer` package [1], accordingly with the recent rewrite in Rust [2]. The `coreos-installer` package will be superseded by `rust-coreos-installer` - and will be deprecated once `rust-coreos-installer` is created. Note that the SRPM linked above was built with the crates `rust-progress-streams` and `rust-cpio` installed in a local buildroot - `rust-coreos-installer` will not build in Koji until those crates are present (pending reviews [3] and [4]). [1] https://src.fedoraproject.org/rpms/coreos-installer [2] https://github.com/coreos/coreos-installer/pull/65 [3] https://bugzilla.redhat.com/show_bug.cgi?id=1784413 [4] https://bugzilla.redhat.com/show_bug.cgi?id=1784412
Updated the description in the specfile to: ``` coreos-installer installs Fedora CoreOS or RHEL CoreOS to bare-metal machines (or, occasionally, to virtual machines). ``` - updated the specfile, SRPM accordingly at the above links.
- You need to add a comment above the patch explaining the changes you've done. - I don't think that is necessary: Obsoletes: coreos-installer < 0.0.1 - You probably need a Provides along the coreos-installer-dracut Obsoletes Provides: coreos-installer-dracut = %{version}-%{release} - License ok - Latest version packaged - Builds in mock - Conforms to Packaging Guidelines
(In reply to Robert-André Mauchin from comment #2) > - I don't think that is necessary: > > Obsoletes: coreos-installer < 0.0.1 Why is this not necessary?
(In reply to Dusty Mabe from comment #3) > (In reply to Robert-André Mauchin from comment #2) > > - I don't think that is necessary: > > > > Obsoletes: coreos-installer < 0.0.1 > > Why is this not necessary? I think I see. It's not necessary because this `rust-coreos-installer` source package creates a `coreos-installer` subpackage and that will have a higher version so the old one will get obsoleted anyway.
(In reply to Dusty Mabe from comment #3) > (In reply to Robert-André Mauchin from comment #2) > > - I don't think that is necessary: > > > > Obsoletes: coreos-installer < 0.0.1 > > Why is this not necessary? This is the same package name with a newer Version-Release, it will automatically supersede coreos-installer < 0.0.1
(In reply to Robert-André Mauchin from comment #2) > - You need to add a comment above the patch explaining the changes you've > done. > Added a comment in the specfile, and also uploaded a diff (sorry, did not upload the diff before): https://rfairley.fedorapeople.org/package-review/rust-coreos-installer-2/coreos-installer-fix-metadata.diff > - I don't think that is necessary: > > Obsoletes: coreos-installer < 0.0.1 > Removed this - makes sense. Added a comment noting why this is removed. > - You probably need a Provides along the coreos-installer-dracut Obsoletes > > Provides: coreos-installer-dracut = %{version}-%{release} > Since the dracut modules will not be included in this package, and will soon be replaced by https://github.com/coreos/coreos-installer/pull/100, I've left the `Provides` out. The `Obsoletes` should be sufficient here. I also updated the specfile for the 0.1.1 version - released recently. Updated specfile and SRPM: Spec URL: https://rfairley.fedorapeople.org/package-review/rust-coreos-installer-2/rust-coreos-installer.spec SRPM URL: https://rfairley.fedorapeople.org/package-review/rust-coreos-installer-2/rust-coreos-installer-0.1.1-1.fc32.src.rpm
LGTM, package approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-coreos-installer
Thank you for reviewing!