Bug 1785041
Summary: | RFE: change vendor preset for fstrim.timer to enabled for Fedora 32 | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Chris Murphy <bugzilla> |
Component: | util-linux | Assignee: | Karel Zak <kzak> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | jonathan, kzak |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2020-02-06 17:10:58 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1790580 |
Description
Chris Murphy
2019-12-18 23:40:22 UTC
ACK, I have not a problem with this plan. Any opinion on whether to apply the change on F30/F31 -> F32 upgrades? I have a slight bias toward not fragmenting the behavior between upgrades and new installations. But I'm not attached to it, either way. If both you and FESCo agree to applying it to upgrades, I'll figure out and submit a PR for Fedora's util-linux that does: %triggerpostun -- fedora-release < 32 systemctl preset fstrim.timer Do we have any feedback from FESCo? I have no problem with it. Their issue was just created, there's a rather strong -1 so far which I don't understand. https://pagure.io/fesco/issue/2309 Draft commit to make sure upgrades get this change. https://src.fedoraproject.org/fork/chrismurphy/rpms/util-linux/c/467f4fd175aaa582f6f98fae30d4136a3bf31a57?branch=devel Hmm, what about people who have Rawhide installed now? They won't get the new behavior unless they clean install, right? What if this is set to "fedora-release < 33" for ~1 month, or ?beta?, and then set it to "fedora-release < 32"? Not a big deal for me, I can set a reminder, if that's the right thing to do. Revised version: https://src.fedoraproject.org/fork/chrismurphy/rpms/util-linux/c/c1151716aaad3680df654955101d5324cd4dc662?branch=cmurfdevel2 So, summary: * we have "yes" from FESCo * 90-default.preset has been updated to enable to fstrim.timer (right?) * util-linux has been updated to %triggerpostun for fedora < 32 https://src.fedoraproject.org/rpms/util-linux/c/20ae04497c34f190e461e47d01ea34c4bbac8116?branch=master Something else? If no, then close this BZ, please. Thanks for your effort and help! Yes, 90-default.preset has been updated. https://src.fedoraproject.org/rpms/fedora-release/pull-request/104 |