Bug 1785041 - RFE: change vendor preset for fstrim.timer to enabled for Fedora 32
Summary: RFE: change vendor preset for fstrim.timer to enabled for Fedora 32
Alias: None
Product: Fedora
Classification: Fedora
Component: util-linux
Version: rawhide
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
Assignee: Karel Zak
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: 1790580
TreeView+ depends on / blocked
Reported: 2019-12-18 23:40 UTC by Chris Murphy
Modified: 2020-02-06 17:10 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2020-02-06 17:10:58 UTC
Type: Bug

Attachments (Terms of Use)

Description Chris Murphy 2019-12-18 23:40:22 UTC
Filing this RFE since the affected unit file is part of util-linux package, and the maintainer may have ack/nack/patch for the proposal.

F32 change proposal is here, feel free to edit as appropriat

Comment 1 Karel Zak 2019-12-19 16:41:22 UTC
ACK, I have not a problem with this plan.

Comment 2 Chris Murphy 2019-12-20 19:07:43 UTC
Any opinion on whether to apply the change on F30/F31 -> F32 upgrades? I have a slight bias toward not fragmenting the behavior between upgrades and new installations. But I'm not attached to it, either way.

If both you and FESCo agree to applying it to upgrades, I'll figure out and submit a PR for Fedora's util-linux that does:

%triggerpostun -- fedora-release < 32
systemctl preset fstrim.timer

Comment 3 Karel Zak 2020-01-02 14:39:19 UTC
Do we have any feedback from FESCo? I have no problem with it.

Comment 4 Chris Murphy 2020-01-02 20:23:45 UTC
Their issue was just created, there's a rather strong -1 so far which I don't understand.

Comment 5 Chris Murphy 2020-01-26 00:13:17 UTC
Draft commit to make sure upgrades get this change.


Comment 6 Chris Murphy 2020-01-26 02:36:23 UTC
Hmm, what about people who have Rawhide installed now? They won't get the new behavior unless they clean install, right?

What if this is set to "fedora-release < 33" for ~1 month, or ?beta?, and then set it to "fedora-release < 32"? Not a big deal for me, I can set a reminder, if that's the right thing to do.

Comment 8 Karel Zak 2020-02-06 11:08:05 UTC
So, summary:

* we have "yes" from FESCo

* 90-default.preset has been updated to enable to fstrim.timer (right?)

* util-linux has been updated to %triggerpostun for fedora < 32

Something else? If no, then close this BZ, please. 

Thanks for your effort and help!

Comment 9 Chris Murphy 2020-02-06 17:08:15 UTC
Yes, 90-default.preset has been updated.

Note You need to log in before you can comment on or make changes to this bug.