Bug 1785968

Summary:	Review Request: python-versioneer - Easy VCS-based management of project version strings
Product:	[Fedora] Fedora	Reporter:	Mukundan Ragavan <nonamedotc>
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, zbyszek
Target Milestone:	---	Flags:	zbyszek: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-12-31 20:06:44 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Mukundan Ragavan 2019-12-22 22:03:22 UTC

Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/versioneer/rnd1/python-versioneer.spec
SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/versioneer/rnd1/python-versioneer-0.18-1.fc31.src.rpm


Description:
Versioneer is a tool to automatically update version strings (in setup.py and
the conventional 'from PROJECT import _version' pattern) by asking your
version- control system about the current tree.

Fedora Account System Username: nonamedotc


koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=39893102

Comment 1 Zbigniew Jędrzejewski-Szmek 2019-12-23 16:34:40 UTC

"version- control system" — space after "-" should be removed.

%description is repeated, defining it once as a macro using %{expand:} would  be nice.

%{python3_sitelib}/__pycache__/*
%{python3_sitelib}/__pycache__/*
is repeated. It would be better to not use a glob, but something like
%{python3_sitelib}/__pycache__/%{pypi_name}.*.py*

%{python3_sitelib}/%{pypi_name}-%{version}-py?.?.egg-info – add "/" a the end if this is a directory.

+ package name is OK
+ license is acceptable for Fedora (public domain)
+ license is specified correctly
  → please use "Public Domain" (capitalized), as in https://fedoraproject.org/wiki/Licensing:Main#Software_License_List.

+ builds and installs OK
+ fedora-review and rmplint seem happy
+ R/P/BR look OK

Package is APPROVED.

Comment 2 Mukundan Ragavan 2019-12-23 21:46:29 UTC

Thanks! I will update make all the changes pointed out during import.

Comment 3 Gwyn Ciesla 2019-12-23 21:49:10 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-versioneer

Comment 4 Mukundan Ragavan 2019-12-31 20:06:44 UTC

Built on rawhide.