Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/versioneer/rnd1/python-versioneer.spec SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/versioneer/rnd1/python-versioneer-0.18-1.fc31.src.rpm Description: Versioneer is a tool to automatically update version strings (in setup.py and the conventional 'from PROJECT import _version' pattern) by asking your version- control system about the current tree. Fedora Account System Username: nonamedotc koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=39893102
"version- control system" — space after "-" should be removed. %description is repeated, defining it once as a macro using %{expand:} would be nice. %{python3_sitelib}/__pycache__/* %{python3_sitelib}/__pycache__/* is repeated. It would be better to not use a glob, but something like %{python3_sitelib}/__pycache__/%{pypi_name}.*.py* %{python3_sitelib}/%{pypi_name}-%{version}-py?.?.egg-info – add "/" a the end if this is a directory. + package name is OK + license is acceptable for Fedora (public domain) + license is specified correctly → please use "Public Domain" (capitalized), as in https://fedoraproject.org/wiki/Licensing:Main#Software_License_List. + builds and installs OK + fedora-review and rmplint seem happy + R/P/BR look OK Package is APPROVED.
Thanks! I will update make all the changes pointed out during import.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-versioneer
Built on rawhide.