Bug 1785974
| Summary: | Review Request: python-qtsass - Compile SCSS files to valid Qt stylesheets | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mukundan Ragavan <nonamedotc> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-03-16 23:36:47 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1770859 | ||
| Bug Blocks: | 1785982 | ||
|
Description
Mukundan Ragavan
2019-12-22 22:12:57 UTC
%description is repeated, defining it once as a macro using %{expand:} would be nice.
%{python3_sitelib}/%{pypi_name} — please add "/" at the end.
- nothing provides python3.8dist(pathtools) >= 0.1.1 needed by python3-watchdog-0.8.3-13.fc32.noarch
Oh, we have python3-watchdog, but it FTI: - nothing provides python3.8dist(pathtools) >= 0.1.1 needed by python3-watchdog-0.8.3-13.fc32.noarch https://bugzilla.redhat.com/show_bug.cgi?id=1770859 With all other reviews done, only this and qdarkstyle remain. We are really waiting for watchdog/pathtools. Looks like we have pathtools in rawhide. @Zbigniew - Can we proceed with the review here? Thanks! I'm AFK until the end of next week. I can finish the review then. If somebody wants to take over before that, please do. @Zbigniew - have time for this? thanks. I see 0.2.2 on github, but 0.1.1 is packaged. Please update to the latest version. 0.2.2 is tagged as a pre-release version. Pypi also has 0.1.1 See - https://pypi.org/project/qtsass/#history It does look like 0.3 is around the horizon though. https://github.com/spyder-ide/qtsass/issues/45 I can upload 0.3 when released and ping again. Yeah, maybe let's wait in that case. If it doesn't happen in a week, I'll just review the older version. Can we move forward with this? 0.3 is not released yet. I would like to get spyder updated to 4.x. Thanks. + package name is OK + latest version + license is acceptable for Fedora (MIT) + license is specified correctly + BR/R/Provides looks OK + builds and installs and works OK on basic examples - %check is missing, it'd be nice to add it Package is APPROVED. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-qtsass Thanks for the review. Built on rawhide. I will add %check with the next change I make. |