Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/qdarkstyle/rnd1/python-qdarkstyle.spec SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/qdarkstyle/rnd1/python-qdarkstyle-2.7-1.fc31.src.rpm Description: A dark stylesheet for Qt applications (Qt4, Qt5, PySide, PySide2, PyQt4, PyQt5, QtPy, PyQtGraph). Fedora Account System Username: nonamedotc
This package is complicated by python-watchdog required pathtools, which has been retired. Also, python-importlib-metadata is missing in rawhide at the moment. https://copr.fedorainfracloud.org/coprs/nonamedotc/spyder4_rawhide/build/1134530/
I'll review this once the two reviews this depends on move forward.
Hmm, builds fails with: + /usr/bin/python3 setup.py test running test WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox. running egg_info writing QDarkStyle.egg-info/PKG-INFO writing dependency_links to QDarkStyle.egg-info/dependency_links.txt writing entry points to QDarkStyle.egg-info/entry_points.txt writing requirements to QDarkStyle.egg-info/requires.txt writing top-level names to QDarkStyle.egg-info/top_level.txt reading manifest file 'QDarkStyle.egg-info/SOURCES.txt' reading manifest template 'MANIFEST.in' warning: no files found matching 'PRODUCTION.md' writing manifest file 'QDarkStyle.egg-info/SOURCES.txt' running build_ext pyside_style_rc (unittest.loader._FailedTest) ... ERROR ====================================================================== ERROR: pyside_style_rc (unittest.loader._FailedTest) ---------------------------------------------------------------------- ImportError: Failed to import test module: pyside_style_rc Traceback (most recent call last): File "/usr/lib64/python3.8/unittest/loader.py", line 154, in loadTestsFromName module = __import__(module_name) File "/builddir/build/BUILD/QDarkStyle-2.7/qdarkstyle/pyside_style_rc.py", line 10, in <module> from PySide import QtCore ModuleNotFoundError: No module named 'PySide' python3-pyside has been retired ;( https://src.fedoraproject.org/rpms/python-pyside/c/73d32307db2c8b1d56c6705f416fc954436dc8f6?branch=master
Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/qdarkstyle/rnd2/python-qdarkstyle.spec SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/qdarkstyle/rnd2/python-qdarkstyle-2.8-1.fc31.src.rpm - Packaged latest upstream version (v2.8) It would be best to use tox for testing. But, not sure how to get this to work. Open to suggestions. Thanks.
> Ran 0 tests in 0.000s Yep, current test invocation doesn't seem to work. I tried running the tests in mock, and I couldn't get it to work either. %tox expands to "... tox --current-env ...", and tox doesn't seem to know this option. When I remove the option, it can't find virtualenv: + tox -q --recreate -e py38 ... ERROR: No matching distribution found for virtualenv but the python3-virtualenv is installed. + package name is OK + license is acceptable for Fedora (MIT) + license is specified correctly (according to setup.py) + builds and install OK + latest version + R/P/BR look OK Package is approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-qdarkstyle
Thanks for the review. Built on rawhide.
*** Bug 1666545 has been marked as a duplicate of this bug. ***