Bug 1786091

Summary:	Wrong behaviour of CD-ROM eject and remove
Product:	OpenShift Container Platform	Reporter:	Guohua Ouyang <gouyang>
Component:	Console Kubevirt Plugin	Assignee:	Tomas Jelinek <tjelinek>
Status:	CLOSED ERRATA	QA Contact:	Nelly Credi <ncredi>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.3.0	CC:	aos-bugs, glekner, gouyang, mcarleto
Target Milestone:	---
Target Release:	4.4.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Cause: Edit CDRom dialog have submitted "remove cdrom" without confirming the dialog Consequence: The user can accidentally remove a cdrom he did not intend to. Fix: the cdrom is removed only upon confirming the action by submitting the dialog Result: The cdrom dialog is consistent with a rest of the application making it much less likely to accidentally remove a cdrom from a vm.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-05-04 11:21:22 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Guohua Ouyang 2019-12-23 11:38:29 UTC

Description of problem:
Add a CD-ROM to a VM and go to the CD-ROM edit page:
- click the remove icon "-", it removes the CD-ROM even without save, which is different from others, for other places, click remove button without save, it does not take effect.
- click "Eject CD-ROM", then either click "Save" or click "Cancel", the CD-ROM is still there in VM overview, the eject button does not work.

Version-Release number of selected component (if applicable):
4.3.0-0.nightly-2019-12-19-050538

How reproducible:
100%

Steps to Reproduce:
1. Go to a VM overview
2. Click the edit icon besides the CD-ROM
3.

Actual results:


Expected results:


Additional info:

Comment 1 Tomas Jelinek 2020-01-06 09:05:39 UTC

@Matt: WDYT?

Comment 2 Matt 2020-01-06 18:12:08 UTC

I agree any action taken in the modal should not take affect until saved. Also, when you eject a cd-rom it should no longer show in the details once you've saved the modal.

Comment 3 Tomas Jelinek 2020-01-07 12:03:47 UTC

@Gilad: in 4.4 it has been enhanced significantly - are the issues from above solved in 4.4?

Comment 4 Gilad Lekner 2020-01-08 13:01:14 UTC

Eject is cosmetic only, it opens the cd for editing and does nothing backend. We should remove it..

About deleting the CD only when pressing Save, if it is the wanted behaviour then it is a bug yes.

Comment 5 Matt 2020-01-08 15:35:35 UTC

+1 on removing the eject.I believe we talked about this already and everyone agreed.

Comment 6 Tomas Jelinek 2020-02-05 11:50:18 UTC

has been fixed by https://github.com/openshift/console/pull/3933
part of https://errata.devel.redhat.com/advisory/47983

Comment 8 Guohua Ouyang 2020-02-18 08:40:36 UTC

verified on 4.4.0-0.nightly-2020-02-10-111955

Comment 11 errata-xmlrpc 2020-05-04 11:21:22 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0581