Description of problem: Add a CD-ROM to a VM and go to the CD-ROM edit page: - click the remove icon "-", it removes the CD-ROM even without save, which is different from others, for other places, click remove button without save, it does not take effect. - click "Eject CD-ROM", then either click "Save" or click "Cancel", the CD-ROM is still there in VM overview, the eject button does not work. Version-Release number of selected component (if applicable): 4.3.0-0.nightly-2019-12-19-050538 How reproducible: 100% Steps to Reproduce: 1. Go to a VM overview 2. Click the edit icon besides the CD-ROM 3. Actual results: Expected results: Additional info:
@Matt: WDYT?
I agree any action taken in the modal should not take affect until saved. Also, when you eject a cd-rom it should no longer show in the details once you've saved the modal.
@Gilad: in 4.4 it has been enhanced significantly - are the issues from above solved in 4.4?
Eject is cosmetic only, it opens the cd for editing and does nothing backend. We should remove it.. About deleting the CD only when pressing Save, if it is the wanted behaviour then it is a bug yes.
+1 on removing the eject.I believe we talked about this already and everyone agreed.
has been fixed by https://github.com/openshift/console/pull/3933 part of https://errata.devel.redhat.com/advisory/47983
verified on 4.4.0-0.nightly-2020-02-10-111955
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:0581