Bug 1788519

Summary:	Missing dependency of pcp-pmda-redis package on perl-autodie and perl-Time-HiRes packages
Product:	Red Hat Enterprise Linux 8	Reporter:	Jan Kurik <jkurik>
Component:	pcp	Assignee:	Nathan Scott <nathans>
Status:	CLOSED DUPLICATE	QA Contact:	Jan Kurik <jkurik>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	8.2	CC:	agerstmayr, hairmare, jkurik, mgoodwin, nathans, patrickm
Target Milestone:	rc	Keywords:	Bugfix, Triaged
Target Release:	8.0
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	pcp-5.1.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-03-18 06:26:14 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jan Kurik 2020-01-07 12:08:27 UTC

Description of problem:
Package pcp-pmda-redis is missing a dependency on perl-autodie and perl-Time-HiRes packages.

Version-Release number of selected component (if applicable):
* pcp-pmda-redis-5.0.2-2.el8

How reproducible:
Always

Steps to Reproduce:
1. Install a fresh RHEL-8.2 system
2. Install pcp-pmda-redis RPM
# yum install -y pcp-pmda-redis pcp-zeroconf
3. Install the PMDA
# cd /var/lib/pcp/pmdas/redis/
# ./Install

Actual results:
# ./Install
Can't locate autodie.pm in @INC (you may need to install the autodie module) (@INC contains:/usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5) at /var/lib/pcp/pmdas/redis/pmdaredis.pl line 66.
...
Can't locate Time/HiRes.pm in @INC (you may need to install the Time::HiRes module) (@INC contains: /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5) at /var/lib/pcp/pmdas/redis/pmdaredis.pl line 71.
...

Expected results:
# ./Install
Updating the Performance Metrics Name Space (PMNS) ...
Terminate PMDA if already installed ...
Updating the PMCD control file, and notifying PMCD ...
Check redis metrics have appeared ... 2 warnings, 71 metrics and 69 values

Additional info:
* This is also reproducible on older RHEL-8 releases
* A workaround is to manually install perl-autodie and perl-Time-HiRes package
# yum install -y perl-autodie perl-Time-HiRes

Comment 1 Nathan Scott 2020-02-19 06:00:09 UTC

commit 364e4011a8fbb1b8545b0f6840d9dd2ca4de5339
Author: Nathan Scott <nathans>
Date:   Wed Feb 19 16:34:21 2020 +1100

    build: update fedora.spec with perl-Time-HiRes package dep for pcp-pmda-redis
    
    Resolves Red Hat BZ #1788519

Comment 2 Lucas Bickel 2020-03-02 22:43:23 UTC

I stumbled upon this by way of #1788510. Does this (or an issue I missed) explicitly cover the `perl-Data-Dumper` dep? 

Upstreams master is directly using it [0] and a quick `yum install pcp-pmda-redis` on a recent centos:8 container image indicates that the dep is missing. Upstreams pagure also lacks the dep [1].

I'd be happy to contribute the needed patch, let me know if it's worth the effort/where I should start. 

[0]: <https://github.com/performancecopilot/pcp/blob/0ab16a9017a1a0b56fbb969bec659be258234dc5/src/pmdas/redis/pmdaredis.pl#L72>
[1]: <https://src.fedoraproject.org/rpms/pcp/blob/f32/f/pcp.spec#_969>

Comment 3 Nathan Scott 2020-03-03 02:36:57 UTC

Hi Lucas,

Yes looks like that is missing - please open a PR for the spec file in upstream PCP
https://github.com/performancecopilot/pcp/blob/master/build/rpm/fedora.spec

Thanks!

Comment 4 Nathan Scott 2020-03-18 06:26:14 UTC

Minor packaging issue, will be resolved via rebase.

*** This bug has been marked as a duplicate of bug 1792971 ***

Comment 5 Jan Kurik 2020-06-12 15:02:15 UTC

Verified on pcp-5.1.1-2.el8 build.