Bug 1790863

Summary: Should not create secret if idp is not created successfully
Product: OpenShift Container Platform Reporter: Jakub Hadvig <jhadvig>
Component: Management ConsoleAssignee: Jakub Hadvig <jhadvig>
Status: CLOSED DUPLICATE QA Contact: Yadan Pei <yapei>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.4CC: aos-bugs, jhadvig, jokerman, yanpzhan, yapei
Target Milestone: ---   
Target Release: 4.3.z   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1790757 Environment:
Last Closed: 2020-01-23 12:07:25 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1790757    
Bug Blocks:    

Description Jakub Hadvig 2020-01-14 12:16:32 UTC
+++ This bug was initially created as a clone of Bug #1790757 +++

Description of problem:
When do negative test for idp, the idp is not created successfully but secret is already created.

Version-Release number of selected component (if applicable):
4.3.0-0.nightly-2020-01-11-070223

How reproducible:
Always

Steps to Reproduce:
1.Create gitlab idp from console, set name, client id, client secret, and input "testurl" in field "URL", click "Add".
2.Check secret in openshift-config project.
3.

Actual results:
1. It will prompt error: "must contain a scheme (e.g. https://)" for field "spec.identityProviders[1].gitlab.url"."
2. New secret prefix with "gitlab-client-secret" is listed in openshift-config project.

Expected results:
2. Should not create secret if idp is not created successfully.


Additional info:

Comment 1 Jakub Hadvig 2020-01-23 12:07:25 UTC

*** This bug has been marked as a duplicate of bug 1790757 ***