Bug 1794346
| Summary: | Change the label for the flashing eye icon during user impersonation | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Satellite | Reporter: | Vlada Grosu <vgrosu> | ||||||
| Component: | Users & Roles | Assignee: | Ondřej Pražák <oprazak> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Peter Ondrejka <pondrejk> | ||||||
| Severity: | low | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 6.7.0 | CC: | egolov, mhulan, oprazak | ||||||
| Target Milestone: | 6.8.0 | Keywords: | Triaged | ||||||
| Target Release: | Unused | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | foreman-2.0.0 | Doc Type: | If docs needed, set a value | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2020-10-27 13:00:04 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Vlada Grosu
2020-01-23 11:01:02 UTC
Created attachment 1655915 [details]
aria-describedby
Thank you for bringing up these very interesting points! A) label for the impersonation/eye icon The intent behind using 'eye icon' is to visually describe the icon in the top bar and make it obvious that 'eye icon' stands for impersonation in the same way the 'bell icon' stands for notifications. If we change 'eye icon' to 'impersonation icon', I can imagine users asking: "Ok, which one is impersonation icon?" as there is no established association between impersonation feature and the icon that visually looks like eye. I think the key here is to establish a link between the impersonation feature and its graphical representation - the eye icon. Maybe we can expand the message a bit, something like: "...to cancel the session, click the yellow blinking eye icon in the top bar representing active impersonation session." What do you think? B) tooltip text of the icon In what way is it ambiguous that the tooltip text does not reference the icon? The tooltip is displayed on hover, so the cursor will be positioned on the icon when the text is displayed. In that situation user needs to "click to stop the impersonation". Do you have any suggestions on what test the tooltip should contain? The icon has aria-describedby attribute, so there should not be a problem with accessibility. Hi Ondrej, Thank you for looking into this. A. To use the same example, when describing the Notifications button we don't mention the bell icon, but we refer to it by its label 'Notifications'. For example, we say "To view Satellite event notification alerts, click the Notifications icon in the upper right of the screen." For the impersonation feature there is a description of the new functionality 'impersonation', an eye icon with the label 'eye icon' and no logical connection between the name of the label and the function of the UI element. I would argue that this is possibly just as confusing for the user as in the case where they would be wondering "Ok, which one is impersonation icon?". Another thought worth considering: how does the 'eye icon' fair with regard to localization? Depending on cultural differences an eye symbol (or word) could potentially mean different things and have various connotations. I honestly don't know. I would prefer not to use such labels in product docs for that reason. I have an idea how to work around this. I found the following topic in the Admin guide: https://access.redhat.com/documentation/en-us/red_hat_satellite/6.6/html-single/administering_red_hat_satellite/index?lb_target=production#form-Red_Hat_Satellite-Administering_Red_Hat_Satellite-Navigation_Tabs_in_the_Satellite_Web_UI We can add an image of the Impersonation icon (to anticipate a user's need for more information) to the existing table and explain what it represents, similar to the bell icon -> Notifications situation. In this case the only thing you would need to do is edit the notification message that is displayed when an impersonation session is started: "You impersonated user Richard Wright, to cancel the session, click the eye icon in the top bar." s/eye/Impersonation B. Thank you for explaining that, it's great that a screen reader would pick up on that text! Thanks for that. What I personally found ambiguous was that the statement doesn't explicitly call out the icon by its label, while the notification message at the start of an impersonation session does. Which is perfectly fine on its own. To be honest, I prefer it that way. I was trying to use this example as an argument against using the 'eye icon'. Apologies for not being clear enough. TLDR - no actions required on your behalf :) Please let me know what you think. Also, do let me know if you would prefer to discuss this over a call, I'd be up for that as well. Many thanks! I think you have found a solution for A. * add an image of Impersonation icon to the table in Admin guide * change the notification message: s/eye/Impersonation/ Thank you! Created redmine issue https://projects.theforeman.org/issues/28895 from this bug Upstream bug assigned to oprazak Upstream bug assigned to oprazak Hi Ondrej, Can you please attach the icon image that I could use for the Admin Guide? I presume you have a suitable format, superior to the quality I would get from a screenshot. :-) Many thanks, Vlada Moving this bug to POST for triage into Satellite 6 since the upstream issue https://projects.theforeman.org/issues/28895 has been resolved. Created attachment 1656684 [details]
fa-eye
I hope this fits your needs.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Important: Satellite 6.8 release), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2020:4366 |