Bug 1795413

Summary:	Review Request: rust-time-macros-impl - Procedural macros for the time crate
Product:	[Fedora] Fedora	Reporter:	Josh Stone <jistone>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-02-12 18:07:18 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1795414

Description Josh Stone 2020-01-27 21:55:30 UTC

Spec URL: https://jistone.fedorapeople.org/review//rust-time-macros-impl.spec
SRPM URL: https://jistone.fedorapeople.org/review//rust-time-macros-impl-0.1.0-1.fc32.src.rpm

Description:
Procedural macros for the time crate.

Comment 1 Josh Stone 2020-01-27 21:55:32 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=41107231

Comment 2 Fabio Valentini 2020-02-10 23:05:58 UTC

- License correct (pull request to ship LICENSE files with the sources was merged)
- package builds in rawhide
- binary packages install in rawhide
- standard rust package, no issues I can see.

Package APPROVED

Can you review one of my pending rust packages in return?

Comment 3 Josh Stone 2020-02-11 23:00:17 UTC

Thanks, I'll get that repo request going. Could you also review at its pair, bug 1795414?

And sure, I'll take a look at your review requests too.

Comment 4 Gwyn Ciesla 2020-02-12 01:35:45 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-time-macros-impl