Bug 1795414 - Review Request: rust-time-macros - Procedural macros for the time crate
Summary: Review Request: rust-time-macros - Procedural macros for the time crate
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1795413
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-01-27 21:58 UTC by Josh Stone
Modified: 2020-02-12 18:32 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-02-12 18:32:03 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+

Attachments (Terms of Use)

Description Josh Stone 2020-01-27 21:58:20 UTC 
Spec URL: https://jistone.fedorapeople.org/review//rust-time-macros.spec
SRPM URL: https://jistone.fedorapeople.org/review//rust-time-macros-0.1.0-1.fc32.src.rpm

Description:
Procedural macros for the time crate.
Comment 1 Josh Stone 2020-01-27 22:00:05 UTC 
Skipped the scratch build because it depends on bug 1795413 for the proc-macro-hack implementation.
Comment 2 Fabio Valentini 2020-02-12 00:31:47 UTC 
Taking this review.
Comment 3 Fabio Valentini 2020-02-12 12:31:12 UTC 
- License correct, pull request to ship LICENSE-* files with the crate was merged upstream
- Latest version is packaged
- Package builds on rawhide (if rust-time-macros-impl is present)
- Package installs on rawhide (if rust-time-macros-impl is present)
- Standard autogenerated rust package with simple fixes

Package APPROVED.
Comment 4 Gwyn Ciesla 2020-02-12 17:32:09 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-time-macros
Note You need to log in before you can comment on or make changes to this bug.