Bug 1795414

Summary:	Review Request: rust-time-macros - Procedural macros for the time crate
Product:	[Fedora] Fedora	Reporter:	Josh Stone <jistone>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-02-12 18:32:03 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1795413
Bug Blocks:

Description Josh Stone 2020-01-27 21:58:20 UTC

Spec URL: https://jistone.fedorapeople.org/review//rust-time-macros.spec
SRPM URL: https://jistone.fedorapeople.org/review//rust-time-macros-0.1.0-1.fc32.src.rpm

Description:
Procedural macros for the time crate.

Comment 1 Josh Stone 2020-01-27 22:00:05 UTC

Skipped the scratch build because it depends on bug 1795413 for the proc-macro-hack implementation.

Comment 2 Fabio Valentini 2020-02-12 00:31:47 UTC

Taking this review.

Comment 3 Fabio Valentini 2020-02-12 12:31:12 UTC

- License correct, pull request to ship LICENSE-* files with the crate was merged upstream
- Latest version is packaged
- Package builds on rawhide (if rust-time-macros-impl is present)
- Package installs on rawhide (if rust-time-macros-impl is present)
- Standard autogenerated rust package with simple fixes

Package APPROVED.

Comment 4 Gwyn Ciesla 2020-02-12 17:32:09 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-time-macros