Bug 1795468
| Summary: | Review Request: mojo-executor - Execute other plugins within a maven plugin | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jerry James <loganjerry> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mizdebsk, package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-02-07 20:55:54 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1795469 | ||
|
Description
Jerry James
2020-01-28 04:09:29 UTC
+ package name is OK + license still OK + latest version + builds and installs OK + fedora-review and rpmlint are OK (one issue below) + R/BR/P look OK + %mvn_* macros are used - Package must not depend on deprecated() packages. Note: sonatype-oss-parent is deprecated, you must not depend on it. In general, this would be a problem. But since this is about bringing back an orphaned package that is required to keep other packages working, it seems appropriate to allow keeping of this dependency. Package is RE-APPROVED. Uh oh. I had heard about sonatype-oss-parent being deprecated but then forgot about it. To my knowledge, mojo-executor has not been in Fedora before. Has it? I don't think this is bringing back an old package; I think this is adding a new one, so the deprecation really is a problem. Is there something that replaces sonatype-oss-parent? I'm willing to work with mojo-executor upstream to move to the replacement, but I don't see a replacement mentioned on https://fedoraproject.org/wiki/Changes/Deprecate_Sonatype_OSS_Parent. Hmm, apparently I got confused. I don't know why I thought that this is a re-review. Too many tabs open I guess. I'm not sure what the plan here is. Maybe Mikołaj can comment. ... I forgot to add: sonatype-oss-parent still builds fine in rawhide, so this is not an immediate problem. Sonatype OSS Parent POMs are not only deprecated in Fedora, but also "no longer work with latest Maven and/or Java versions", see README.md at upstream GitHub page: https://github.com/sonatype/oss-parents In all cases I know build-dependency on sonatype-oss-parent can be removed from downstream (Fedora) package builds without affecting package build. %pom_remove_parent macro can be used to achieve that, https://fedora-java.github.io/howto/latest/#pom_remove_parent Thank you, Mikolaj. You are quite right: I can drop the BR on sonatype-oss-parent and add %pom_remove_parent to %prep, and the package builds without trouble. Zbigniew, since you already approved this package, my plan is to request a repo and add %pom_remove_parent to %prep when I import. Let me know if you want me to do otherwise. Thanks for the review! (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/mojo-executor > request a repo and add %pom_remove_parent to %prep when I import
+1
Built in Rawhide. |