Spec URL: https://jjames.fedorapeople.org/string-template-maven-plugin/string-template-maven-plugin.spec SRPM URL: https://jjames.fedorapeople.org/string-template-maven-plugin/string-template-maven-plugin-1.1-1.fc32.src.rpm Fedora Account System Username: jjames Description: This plugin allows you to execute StringTemplate template files during your build. The values for templates can come from static declarations or from a Java class specified to be executed.
Looks like I was too late for the other two :) But once they are built, I'll review this package and antlr4.
My suggestion would be to simply build and install the dependency in mock, and then review this one using "mock -o ' -n' -b 1795469" or similar. Apart from saving time, this has the advantage that it provides an additional test for those dependencies. It is possible that something was missed in review (e.g. some forgotten provides or a runtime issue), and building this package on top might allow us to catch those bugs earlier than we would otherwise.
Manual review below (with dependent packages built and installed in mock manually): - License is correct and permissible - Package builds and installs correctly - Package conforms to (Java) Packaging Guidelines - Patches are documented and justified - rpmlint shows no issues ================ Package APPROVED ================ Non-blocking suggestion: I'm pretty sure BR: maven-source-plugin is not actually necessary since the build doesn't produce source JARs. You should be able to remove the BR from the build, as well (with %pom_remove_plugin :maven-source-plugin"). It's not strictly necessary to do that, but it makes your package's dependency tree smaller and probably makes mock/koji builds marginally faster.
Ah, one thing I forgot: It looks like the last upstream release doesn't contain a COPYING / LICENSE file (it's there in git master, but git hasn't been touched since 2013). However, it looks like the README.md file contains the text of the actual license. You should probably add "%license README.md" in this case.
Thanks for the suggestions. I will apply both of those when I import the package. Thank you for the review!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/string-template-maven-plugin
Built in Rawhide.