Bug 1795897

Summary:	Remove python-thrift dependency from python-elasticsearch
Product:	OpenShift Container Platform	Reporter:	Sam Fowler <sfowler>
Component:	Logging	Assignee:	Jeff Cantrill <jcantril>
Status:	CLOSED ERRATA	QA Contact:	Anping Li <anli>
Severity:	low	Docs Contact:
Priority:	low
Version:	4.4	CC:	aos-bugs, periklis, sfowler
Target Milestone:	---
Target Release:	4.4.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:
Clones:	1795899 1822686 (view as bug list)		Environment:
Last Closed:	2020-08-04 14:16:01 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1822686
Bug Blocks:	1795899, 1795900, 1795901, 1795902

Description Sam Fowler 2020-01-29 07:24:15 UTC

The python-elasticsearch RPM has a dependency on the python-thrift RPM,
however the Changelog and source code indicates this is no longer needed
(removed in version 1.8.0, 'thrift' does not appear in source).

According to changelog, thrift was removed from elasticsearch-py in 1.8.0 (that was 2015 and Elasticsearch < 2.0.0):
https://github.com/elastic/elasticsearch-py/blob/07fef33accc28e057c9edf2cd730c72d3a835b21/Changelog.rst#180-2015-10-14

The only Logging component using python-elasticsearch seems to be Curator (https://github.com/openshift/origin-aggregated-logging/tree/master/curator).

We should be able to remove the python-thrift dep from python-elasticsearch, and drop the thrift SRPM from OCP 4.4 (and future releases).

Comment 2 Jeff Cantrill 2020-06-18 19:20:26 UTC

Moving to UpcomingSprint as wont be resolved by EOS

Comment 3 Periklis Tsirakidis 2020-07-10 14:30:19 UTC

Moving to UpcomingSprint unlikely to get merged until EOS.

Comment 7 Anping Li 2020-07-22 06:30:11 UTC

The latest curator images are 202007120152.p0. No images include this fix.

Comment 8 Luke Meyer 2020-07-23 02:14:12 UTC

Dockerfile needs a fix.

Comment 9 Luke Meyer 2020-07-23 21:44:44 UTC

Not fixed yet, e.g. https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=30288935

Comment 13 Anping Li 2020-07-27 06:29:31 UTC

No python-thrift in openshift/ose-logging-curator5:202007240028.p0

Comment 15 errata-xmlrpc 2020-08-04 14:16:01 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.4.15 bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:3128