Bug 1795897 - Remove python-thrift dependency from python-elasticsearch
Summary: Remove python-thrift dependency from python-elasticsearch
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Logging
Version: 4.4
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: 4.4.z
Assignee: Jeff Cantrill
QA Contact: Anping Li
URL:
Whiteboard:
Depends On: 1822686
Blocks: 1795899 1795900 1795901 1795902
TreeView+ depends on / blocked
 
Reported: 2020-01-29 07:24 UTC by Sam Fowler
Modified: 2020-08-04 14:16 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
: 1795899 1822686 (view as bug list)
Environment:
Last Closed: 2020-08-04 14:16:01 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift origin-aggregated-logging pull 1887 0 None closed Bug 1795897: Move curator to python 3, remove python-thrift 2020-09-24 03:52:41 UTC
Github openshift origin-aggregated-logging pull 1948 0 None closed Bug 1795897: curator: base on py36 2020-09-24 03:52:37 UTC
Github openshift origin-aggregated-logging pull 1949 0 None closed Bug 1795897: curator/Dockerfile: don't be picky about where pip installs curator 2020-09-24 03:52:37 UTC
Red Hat Product Errata RHBA-2020:3128 0 None None None 2020-08-04 14:16:34 UTC

Description Sam Fowler 2020-01-29 07:24:15 UTC
The python-elasticsearch RPM has a dependency on the python-thrift RPM,
however the Changelog and source code indicates this is no longer needed
(removed in version 1.8.0, 'thrift' does not appear in source).

According to changelog, thrift was removed from elasticsearch-py in 1.8.0 (that was 2015 and Elasticsearch < 2.0.0):
https://github.com/elastic/elasticsearch-py/blob/07fef33accc28e057c9edf2cd730c72d3a835b21/Changelog.rst#180-2015-10-14

The only Logging component using python-elasticsearch seems to be Curator (https://github.com/openshift/origin-aggregated-logging/tree/master/curator).

We should be able to remove the python-thrift dep from python-elasticsearch, and drop the thrift SRPM from OCP 4.4 (and future releases).

Comment 2 Jeff Cantrill 2020-06-18 19:20:26 UTC
Moving to UpcomingSprint as wont be resolved by EOS

Comment 3 Periklis Tsirakidis 2020-07-10 14:30:19 UTC
Moving to UpcomingSprint unlikely to get merged until EOS.

Comment 7 Anping Li 2020-07-22 06:30:11 UTC
The latest curator images are 202007120152.p0. No images include this fix.

Comment 8 Luke Meyer 2020-07-23 02:14:12 UTC
Dockerfile needs a fix.

Comment 9 Luke Meyer 2020-07-23 21:44:44 UTC
Not fixed yet, e.g. https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=30288935

Comment 13 Anping Li 2020-07-27 06:29:31 UTC
No python-thrift in openshift/ose-logging-curator5:202007240028.p0

Comment 15 errata-xmlrpc 2020-08-04 14:16:01 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.4.15 bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:3128


Note You need to log in before you can comment on or make changes to this bug.