Bug 1795900

Summary: Remove python-thrift dependency from python-elasticsearch
Product: OpenShift Container Platform Reporter: Sam Fowler <sfowler>
Component: LoggingAssignee: Jeff Cantrill <jcantril>
Status: CLOSED WONTFIX QA Contact: Anping Li <anli>
Severity: low Docs Contact:
Priority: unspecified    
Version: 4.2.zCC: anli, aos-bugs, jcantril, sfowler
Target Milestone: ---   
Target Release: 4.2.z   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1795899
: 1795901 (view as bug list) Environment:
Last Closed: 2020-04-28 00:49:03 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1795897, 1795899, 1822686    
Bug Blocks: 1795901, 1795902    

Description Sam Fowler 2020-01-29 07:29:24 UTC
+++ This bug was initially created as a clone of Bug #1795899 +++

+++ This bug was initially created as a clone of Bug #1795897 +++

The python-elasticsearch RPM has a dependency on the python-thrift RPM,
however the Changelog and source code indicates this is no longer needed
(removed in version 1.8.0, 'thrift' does not appear in source).

According to changelog, thrift was removed from elasticsearch-py in 1.8.0 (that was 2015 and Elasticsearch < 2.0.0):
https://github.com/elastic/elasticsearch-py/blob/07fef33accc28e057c9edf2cd730c72d3a835b21/Changelog.rst#180-2015-10-14

The only Logging component using python-elasticsearch seems to be Curator (https://github.com/openshift/origin-aggregated-logging/tree/master/curator).

We should be able to remove the python-thrift dep from python-elasticsearch, and drop the thrift SRPM from OCP 4.4 (and future releases).

Comment 1 Jeff Cantrill 2020-04-28 00:49:03 UTC
Closing given 4.2 is EOL