Bug 1800470

Summary:	'oc get volumesnapshotclass' should show deletionPolicy/driver info
Product:	OpenShift Container Platform	Reporter:	Liang Xia <lxia>
Component:	Storage	Assignee:	Christian Huffman <chuffman>
Status:	CLOSED ERRATA	QA Contact:	Wei Duan <wduan>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.4	CC:	aos-bugs, chuffman, jokerman, jsafrane, lxia, mfojtik, wduan
Target Milestone:	---
Target Release:	4.5.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:	Feature: Included additional details when querying VolumeSnapshotClass resources. Reason: The `oc get` information only displayed the name and creation time of the resource. Result: Now the `oc get` information includes additional details, such as the associated CSI Driver and deletion policy.	Story Points:	---
Clone Of:
Clones:	1808337 (view as bug list)		Environment:
Last Closed:	2020-07-13 17:14:25 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1808337

Description Liang Xia 2020-02-07 07:53:31 UTC

Description of problem:
Request 'oc get volumesnapshotclass' to show deletionPolicy/driver info.
Currently, it only show name/age info.

Version-Release number of selected component (if applicable):
openshift-clients-4.4.0-202002052231.git.1.3433f68.el7.x86_64

How reproducible:
Always

Steps to Reproduce:
1. oc get volumesnapshotclass


Actual results:
$ oc get volumesnapshotclass
NAME            AGE
ceph-rbd-snap   20m

$ oc get volumesnapshotclass ceph-rbd-snap -o yaml
apiVersion: snapshot.storage.k8s.io/v1beta1
deletionPolicy: Delete
driver: openshift-storage.rbd.csi.ceph.com
kind: VolumeSnapshotClass
metadata:
  creationTimestamp: "2020-02-07T07:15:48Z"
  generation: 1
  name: ceph-rbd-snap
  resourceVersion: "109436"
  selfLink: /apis/snapshot.storage.k8s.io/v1beta1/volumesnapshotclasses/ceph-rbd-snap
  uid: 25b2d701-d8ef-4bce-8bb4-65e238ebeb26


Expected results:
VolumeSnapshotClass is quite similar to StorageClass, it is better to show info deletionPolicy/driver


Additional info:
$ oc get storageclass
NAME                          PROVISIONER                             RECLAIMPOLICY   VOLUMEBINDINGMODE      ALLOWVOLUMEEXPANSION   AGE
ocs-storagecluster-ceph-rbd   openshift-storage.rbd.csi.ceph.com      Delete          Immediate              false                  74m
ocs-storagecluster-cephfs     openshift-storage.cephfs.csi.ceph.com   Delete          Immediate              false                  74m
openshift-storage.noobaa.io   openshift-storage.noobaa.io/obc         Delete          Immediate              false                  68m
standard (default)            kubernetes.io/gce-pd                    Delete          WaitForFirstConsumer   true                   4h6m

Comment 1 Maciej Szulik 2020-02-10 13:42:08 UTC

The printing is defined on the server, the owners of the component are responsible for updating the printers on the server.
Moving to storage team to update.

Comment 3 Christian Huffman 2020-02-17 21:56:10 UTC

Upstream PR has been submitted at [1].

[1] https://github.com/kubernetes-csi/external-snapshotter/pull/256

Comment 4 Christian Huffman 2020-02-27 19:20:12 UTC

Upstream PR has been merged. I've submitted [1] to include this in the operator we ship.

[1] https://github.com/openshift/cluster-csi-snapshot-controller-operator/pull/30

Comment 6 Jan Safranek 2020-02-28 09:14:23 UTC

Fixed by https://github.com/openshift/cluster-csi-snapshot-controller-operator/pull/30

Comment 7 Liang Xia 2020-02-28 09:49:08 UTC

Cloned https://bugzilla.redhat.com/show_bug.cgi?id=1808337 to 4.4 to track the issues in https://bugzilla.redhat.com/show_bug.cgi?id=1800477, https://bugzilla.redhat.com/show_bug.cgi?id=1800437 and https://bugzilla.redhat.com/show_bug.cgi?id=1800470

Comment 10 Wei Duan 2020-03-13 02:50:09 UTC

Verified pass with following result:

[wduan@MINT config]$ oc get clusterversion
NAME      VERSION                             AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.5.0-0.nightly-2020-03-12-212933   True        False         26m     Cluster version is 4.5.0-0.nightly-2020-03-12-212933

[wduan@MINT snapshot]$ oc create -f VolumeSnapshotClass.yaml
volumesnapshotclass.snapshot.storage.k8s.io/csi-snapclass created
[wduan@MINT snapshot]$ oc get volumesnapshotclass
NAME            DRIVER               DELETIONPOLICY   AGE
csi-snapclass   disk.csi.azure.com   Delete           16s

Comment 12 errata-xmlrpc 2020-07-13 17:14:25 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409