Bug 180154

Summary: PATCH: fix digmid loading of timidity midi patches
Product: [Fedora] Fedora Reporter: Hans de Goede <hdegoede>
Component: allegroAssignee: Jindrich Novy <jnovy>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: extras-qa, pknirsch
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-02-07 12:52:34 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
patch fixing digmid wavesynth none

Description Hans de Goede 2006-02-06 11:31:05 UTC 
After my allgrorc fix to use timidity.cfg for the allegro digmid software
wavetable midi synth, the initialising of sound with midi works, but things are
still very quiet, this is because timidity.cfg contains absolute patch path's
and digmid can't handle these.

The attached patch fixes this, I'll also send it upstream.
Comment 1 Hans de Goede 2006-02-06 11:31:06 UTC 
Created attachment 124251 [details]
patch fixing digmid wavesynth
Comment 2 Jindrich Novy 2006-02-06 14:11:37 UTC 
Could you please write here a link to the upstream list where you send this fix
so that I can see the discussion? Thanks.
Comment 3 Hans de Goede 2006-02-06 19:26:53 UTC 
I send it to alleg-developers.net, here is the reply I got:

On Mon, 2006-02-06 at 12:46 +0100, Hans de Goede wrote:
> > Hi all,
> > 
> > I'm working on the Linux port of Worminator3 an allegro using game and 
> > had some trouble to get midi sound to work.
> > 
> > Under most Linux distributions there is a softwavesynth called 
> > timidity++ which comes with a set of gus-patches, I choose to use this 
> > as patchset.
> > 
> > This made install_sound (from memory, more general sound-init) happy, 
> > however no midi songs could be heard, after some debugging I found out 
> > that digmid cannot handle patches.cfg files with absolute paths, the 
> > attached patch fixes this.

Thanks, committed it, with a small chage: Instead of increasing the path
size from 32 to 64, I increased it to 1024, which is what is used
throughout Allegro.

-- Elias Pschernig
Comment 4 Jindrich Novy 2006-02-07 12:52:34 UTC 
Applied. Thanks.